Replace Travis CI with GitHub CI #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the Travis CI have deprecated, we should move this to GitHub CI instead. We also bump the minimum Elixir requirement to 1.13.
kianmeng
commented
Aug 10, 2024
| @@ -50,7 +50,7 @@ defmodule Countries.Loader do | |||
| do: to_map(values) | |||
|
|
|||
| defp convert_value(attribute, value) | |||
| when is_list(value) and not (attribute in @do_not_convert), | |||
| when is_list(value) and attribute not in @do_not_convert, | |||
There was a problem hiding this comment.
Changes modified by mix format
kianmeng
commented
Aug 10, 2024
| @@ -1,10 +1,9 @@ | |||
| %{ | |||
| "earmark": {:hex, :earmark, "1.3.1", "73812f447f7a42358d3ba79283cfa3075a7580a3a2ed457616d6517ac3738cb9", [:mix], [], "hexpm", "000aaeff08919e95e7aea13e4af7b2b9734577b3e6a7c50ee31ee88cab6ec4fb"}, | |||
There was a problem hiding this comment.
$ mix deps.unlock --check-unused
warning: use Mix.Config is deprecated. Use the Config module instead
│
3 │ use Mix.Config
│ ~~~~~~~~~~~~~~
│
└─ config/config.exs:3
** (Mix) Unused dependencies in mix.lock file:
* :earmark
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the Travis CI have deprecated, we should move this to GitHub CI instead. We also bump the minimum Elixir requirement to 1.13.