Add Version Number to External JS Filenames #388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the version number to jsyaml a few commits ago. But that was incomplete: 1) I changed the filename and added the import in test_common, but I forgot to update the script tag in index.html. 2) I should have made the same change to the external lz string library. jsyaml now has the version number in the filename everywhere it's referenced. The LZString library has been given the same treatment. The 1.5.0 was added to the filename, the script tag reference was updated, and the LZString library has been added to global in test_common in line with the others.
jertel
approved these changes
Mar 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the version number to jsyaml a few commits ago. But that was incomplete:
jsyaml now has the version number in the filename everywhere it's referenced.
The LZString library has been given the same treatment. The 1.5.0 was added to the filename, the script tag reference was updated, and the LZString library has been added to global in test_common in line with the others.