Duplication Fixes, Improvements #423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cleaned up how we process a detection returned from the API so we always do everything we need to do. This fixes a weird issue with duplication where after duplicating you could hit cancel on the Detection Source tab and the page would convert back to the previous detection you had duplicated. `convertDetection` no longer accepts parameters. It uses `this.detect` which is fine for both new and pre-existing detection conversion. Fixed a case insensitive comparison that was hiding the Convert button on the New Detection screen.
defensivedepth
approved these changes
Apr 10, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleaned up how we process a detection returned from the API so we always do everything we need to do. This fixes a weird issue with duplication where after duplicating you could hit cancel on the Detection Source tab and the page would convert back to the previous detection you had duplicated.
convertDetectionno longer accepts parameters. It usesthis.detectwhich is fine for both new and pre-existing detection conversion.Fixed a case insensitive comparison that was hiding the Convert button on the New Detection screen.