Sanitize Strings #441
Merged
Sanitize Strings #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gridmembershandler.go had a custom implemented sanitize function, replaced it with the sanitize library of choice we use else where in the project. PublicIds are used in a few places to name files being written to disk so some extra care was taken to be sure we validate them more stringently and sanitize them before use. They are, after all, externally provided content. More test cases for validateId to ensure file paths or even the characters used in file paths aren't acceptable regardless of slash direction. This is used upstream of where we use PublicIds for file names.
jertel
approved these changes
Apr 25, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gridmembershandler.go had a custom implemented sanitize function, replaced it with the sanitize library of choice we use else where in the project.
PublicIds are used in a few places to name files being written to disk so some extra care was taken to be sure we validate them more stringently and sanitize them before use. They are, after all, externally provided content.
More test cases for validateId to ensure file paths or even the characters used in file paths aren't acceptable regardless of slash direction. This is used upstream of where we use PublicIds for file names.