feat(ui): bulk remove vulnerabilities #168

0b3ud · 2024-08-26T21:17:38Z

Add Feature feat(ui): Bulk remove vulnerabilities #43

Reading this issue I was able to split this feature in two tasks :

Selecting all vulnerabilities in vulnerability page
Bulk deleting selected vulnerabilities

Selecting all vulnerabilities in vulnerability page :

Edited template in web/templates/base/_items/vulnerability_tab_content.html :

Added input called select_all_checkbox

Bulk deleting selected vulnerabilities :

Added a button for bulk deleting in template
File : web/templates/base/_items/vulnerability_tab_content.html

Results :

I've tested both function using the results of a scan I did on a metasploitable machine 💯
Selecting all seems to work 👍
Bulk deletion seems to work 👍

I would appreciate it if you can do some tests on your side and notify me if there are any bugs

Summary by Sourcery

Implement bulk operations for vulnerabilities, including selecting all, resolving, and deleting multiple vulnerabilities at once. Enhance the user interface to support these operations and improve the dynamic status update of vulnerabilities.

New Features:

Introduce a feature to select all vulnerabilities on the vulnerability page, allowing users to manage multiple vulnerabilities at once.
Add functionality for bulk deleting selected vulnerabilities, streamlining the process of removing multiple vulnerabilities simultaneously.

Enhancements:

Improve the user interface by adding buttons for bulk operations such as opening, resolving, and deleting selected vulnerabilities.
Enhance the vulnerability status change function to update the UI dynamically, reflecting the current status of vulnerabilities.

AnonymousWP · 2024-08-26T21:20:01Z

Any reason why some of the content of your PR description is quoted?

0b3ud · 2024-08-26T21:25:31Z

Nope just wanted it to be easier to read
It turned out to be confusing my bad

web/startScan/templates/startScan/vulnerabilities.html

web/templates/base/_items/vulnerability_tab_content.html

0b3ud · 2024-09-04T10:18:02Z

Sept 4th 2024 Update :

This PR will add the following features :

Selecting all vulnerabilities in vulnerability page
Bulk deleting selected vulnerabilities
Bulk changing vulnerabilities status
Status Badge is clickable

I have changed the color of the trash button and put it in red
Collaborated with @psyray to make the status badges clickable to change vulnerability status
Added buttons resolve all and open all to change status of selected vulnerabilities

On my behalf I have tested it, and it seems to work 💯
Let me know if you identify any bugs 🥇

psyray

@0b3ud Thanks for this.

Could you use the Blue color for the open state, red is already used for vuln severity and it could be confusing

To be consistent with other tables could you move the mass actions buttons to the left side like in the subdomain table

And move the select all checkbox at the top of the table

0b3ud · 2024-09-06T16:09:10Z

Hey
Thanks for the review
Sure on it

@0b3ud Thanks for this.

Could you use the Blue color for the open state, red is already used for vuln severity and it could be confusing

To be consistent with other tables could you move the mass actions buttons to the left side like in the subdomain table

And move the select all checkbox at the top of the table

web/templates/base/_items/vulnerability_tab_content.html

…end Request on each select_all click

0b3ud · 2024-09-06T20:08:04Z

Sept 6th Update :

As requested I have changed the following :

Blue color for the open state
The mass actions buttons moved to the left side like in the subdomain table
Select all button is now in the table header
Changed some text and Added some icons :)

AnonymousWP · 2024-09-07T11:31:32Z

@0b3ud Can you check the checkboxes where applicable? e.g. beginning of this PR and your latest post. Not checking them indicates it's not done.

0b3ud · 2024-09-07T13:18:08Z

@0b3ud Can you check the checkboxes where applicable? e.g. beginning of this PR and your latest post. Not checking them indicates it's not done.

Done :)

psyray · 2024-09-07T18:05:21Z

Don't have tested yet.
Tomorrow

psyray · 2024-09-10T14:45:38Z

@sourcery-ai review

sourcery-ai · 2024-09-10T14:45:46Z

Reviewer's Guide by Sourcery

This pull request implements a new feature for bulk removal of vulnerabilities in the UI. The changes include adding a select-all checkbox for vulnerabilities, implementing bulk deletion functionality, and modifying the vulnerability status change mechanism.

File-Level Changes

Change	Details	Files
Implemented bulk selection and deletion of vulnerabilities	Added a select-all checkbox for vulnerabilities Implemented a bulk delete button and its functionality Created a new function 'bulk_vuln_status_change' to handle bulk status changes Modified the vulnerability table to include checkboxes for each vulnerability	`web/templates/base/_items/vulnerability_tab_content.html` `web/static/custom/custom.js` `web/startScan/templates/startScan/vulnerabilities.html`
Updated vulnerability status change mechanism	Modified 'vuln_status_change' function to handle both OPEN and RESOLVED statuses Updated the UI to show clickable status badges for each vulnerability Added buttons for bulk opening and resolving of selected vulnerabilities	`web/static/custom/custom.js` `web/startScan/templates/startScan/vulnerabilities.html` `web/templates/base/_items/vulnerability_tab_content.html`
Adjusted UI elements and styling	Modified badge padding in custom.css Updated click event handling for vulnerability table rows Adjusted column widths and classes in the vulnerability table	`web/static/custom/custom.css` `web/startScan/templates/startScan/detail_scan.html` `web/targetApp/templates/target/summary.html` `web/startScan/templates/startScan/vulnerabilities.html`

Tips

Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
Continue your discussion with Sourcery by replying directly to review comments.
You can change your review settings at any time by accessing your dashboard:
- Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
- Change the review language;
You can always contact us if you have any questions or feedback.

sourcery-ai

Hey @0b3ud - I've reviewed your changes and found some issues that need to be addressed.

Blocking issues:

Avoid hardcoding credentials in the code. (link)

Overall Comments:

Consider adding an extra confirmation step or more explicit UI warnings for bulk delete operations to prevent accidental data loss.
Some JavaScript functions, particularly those handling bulk operations, could be optimized for better performance with large datasets.

Here's what I looked at during the review

🟢 General issues: all looks good
🔴 Security: 1 blocking issue
🟢 Testing: all looks good
🟡 Complexity: 1 issue found
🟢 Documentation: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

web/static/custom/custom.js

AnonymousWP · 2024-09-12T12:03:17Z

Please finish this up so I can test this (after sourcery's suggestions).

0b3ud · 2024-09-12T13:17:03Z

Please finish this up so I can test this (after sourcery's suggestions).

Done you can test it now :)

psyray · 2024-09-18T19:48:28Z

Please finish this up so I can test this (after sourcery's suggestions).

Done you can test it now :)

Near perfect, just one thing, you need to disable mass change buttons if no checkbox is checked.
And if it's checked you display the number of checked vulns
Like in the subdomains list

Disabled

Enabled

function onchange(event) {
  toggleMultipleSubdomainButton()
}
function toggleMultipleSubdomainButton() {
  var checked_count = checkedCount();
  if (checked_count > 0) {
    $("[data-button=subdomain_btns]").removeClass("disabled");
    $('#subdomain_selected_count').text(checked_count + ' Subdomains Selected x');
  } else {
    $("[data-button=subdomain_btns]").addClass("disabled");
    $('#subdomain_selected_count').empty();
  }
}

0b3ud · 2024-09-20T10:22:24Z

Please finish this up so I can test this (after sourcery's suggestions).

Done you can test it now :)

Near perfect, just one thing, you need to disable mass change buttons if no checkbox is checked. And if it's checked you display the number of checked vulns Like in the subdomains list

Disabled

Enabled
function onchange(event) {
  toggleMultipleSubdomainButton()
}
function toggleMultipleSubdomainButton() {
  var checked_count = checkedCount();
  if (checked_count > 0) {
    $("[data-button=subdomain_btns]").removeClass("disabled");
    $('#subdomain_selected_count').text(checked_count + ' Subdomains Selected x');
  } else {
    $("[data-button=subdomain_btns]").addClass("disabled");
    $('#subdomain_selected_count').empty();
  }
}

Hey @psyray
Would you able to check
I have added the feature as demanded :)

…lection

web/templates/base/_items/vulnerability_tab_content.html

psyray · 2024-09-06T13:28:26Z

web/startScan/templates/startScan/vulnerabilities.html

@@ -298,7 +293,7 @@

 	$('#vulnerability_results').on('click', 'tr' , function (e) {
 		console.log(e.target);


Could you remove this console log

0b3ud added 2 commits August 26, 2024 22:50

feat(vulnerabilities page): add bulk delete button

bb57f6f

feat(vulnerabilities page): add select all checkbox

170f856

0b3ud added the enhancement New feature or request label Aug 26, 2024

0b3ud requested a review from psyray August 26, 2024 21:17

0b3ud self-assigned this Aug 26, 2024

0b3ud linked an issue Aug 26, 2024 that may be closed by this pull request

feat(ui): Bulk remove vulnerabilities #43

Closed

1 task

0b3ud added enhancement New feature or request and removed enhancement New feature or request labels Aug 26, 2024

psyray reviewed Aug 28, 2024

View reviewed changes

web/startScan/templates/startScan/vulnerabilities.html Outdated Show resolved Hide resolved

psyray reviewed Aug 28, 2024

View reviewed changes

web/templates/base/_items/vulnerability_tab_content.html Outdated Show resolved Hide resolved

psyray reviewed Aug 28, 2024

View reviewed changes

web/templates/base/_items/vulnerability_tab_content.html Show resolved Hide resolved

0b3ud added 5 commits September 3, 2024 01:10

Merge branch 'release/2.1.0' into bulk_del_vulns

9b0048d

feat(ui-ux): change status clicking on badge

89e0150

fix(ui): Select all

b2b2866

fix(vulnerabilities page): correct bulk delete

2b03837

feat(vulnerabilities page): resolve and open all selected vulns at once

f5d4c39

fix(customjs): add back deleted code by mistake

d7658ab

psyray requested changes Sep 6, 2024

View reviewed changes

enhancement(ui) : add icons and change some colors

ca7b24c

github-advanced-security bot found potential problems Sep 6, 2024

View reviewed changes

web/templates/base/_items/vulnerability_tab_content.html Fixed Show fixed Hide fixed

web/templates/base/_items/vulnerability_tab_content.html Fixed Show fixed Hide fixed

0b3ud added 4 commits September 6, 2024 19:48

fix(ui): Remove empty id form button

1fbbe36

fix(bug): Remove sorting attribute on checkboxes so the app doesn't s…

818f560

…end Request on each select_all click

enhancement(ui): change text on buttons

035c3dd

fix(bug): remove consol.log

7ff4060

sourcery-ai bot reviewed Sep 10, 2024

View reviewed changes

web/static/custom/custom.js Show resolved Hide resolved

web/static/custom/custom.js Show resolved Hide resolved

Refactor : Rewrite functions to make them more readable

5b6295e

feat(ui) : toggle multiple vulnerabilities

6176548

feat(ui) : add vulnerabilities counter enable/disable btns on vuln se…

c330308

…lection

github-advanced-security bot found potential problems Sep 20, 2024

View reviewed changes

web/templates/base/_items/vulnerability_tab_content.html Fixed Show resolved Hide resolved

fix(ui) : remove useless Id

7afbd95

psyray approved these changes Sep 22, 2024

View reviewed changes

psyray merged commit 8b6313b into Security-Tools-Alliance:release/2.1.0 Sep 22, 2024
3 checks passed

psyray mentioned this pull request Sep 24, 2024

feat(ui): Bulk remove vulnerabilities #43

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(ui): bulk remove vulnerabilities #168

feat(ui): bulk remove vulnerabilities #168

0b3ud commented Aug 26, 2024 •

edited by sourcery-ai bot

Loading

AnonymousWP commented Aug 26, 2024

0b3ud commented Aug 26, 2024

0b3ud commented Sep 4, 2024 •

edited

Loading

psyray left a comment •

edited

Loading

0b3ud commented Sep 6, 2024

0b3ud commented Sep 6, 2024 •

edited

Loading

AnonymousWP commented Sep 7, 2024

0b3ud commented Sep 7, 2024

psyray commented Sep 7, 2024

psyray commented Sep 10, 2024

sourcery-ai bot commented Sep 10, 2024 •

edited

Loading

sourcery-ai bot left a comment

AnonymousWP commented Sep 12, 2024

0b3ud commented Sep 12, 2024

psyray commented Sep 18, 2024

0b3ud commented Sep 20, 2024

psyray Sep 6, 2024

		@@ -298,7 +293,7 @@

		$('#vulnerability_results').on('click', 'tr' , function (e) {
		console.log(e.target);

feat(ui): bulk remove vulnerabilities #168

feat(ui): bulk remove vulnerabilities #168

Conversation

0b3ud commented Aug 26, 2024 • edited by sourcery-ai bot Loading

Reading this issue I was able to split this feature in two tasks :

Selecting all vulnerabilities in vulnerability page :

Results :

Summary by Sourcery

AnonymousWP commented Aug 26, 2024

0b3ud commented Aug 26, 2024

0b3ud commented Sep 4, 2024 • edited Loading

Sept 4th 2024 Update :

This PR will add the following features :

psyray left a comment • edited Loading

Choose a reason for hiding this comment

0b3ud commented Sep 6, 2024

0b3ud commented Sep 6, 2024 • edited Loading

Sept 6th Update :

As requested I have changed the following :

AnonymousWP commented Sep 7, 2024

0b3ud commented Sep 7, 2024

psyray commented Sep 7, 2024

psyray commented Sep 10, 2024

sourcery-ai bot commented Sep 10, 2024 • edited Loading

Reviewer's Guide by Sourcery

File-Level Changes

sourcery-ai bot left a comment

Choose a reason for hiding this comment

AnonymousWP commented Sep 12, 2024

0b3ud commented Sep 12, 2024

psyray commented Sep 18, 2024

0b3ud commented Sep 20, 2024

psyray Sep 6, 2024

Choose a reason for hiding this comment

0b3ud commented Aug 26, 2024 •

edited by sourcery-ai bot

Loading

0b3ud commented Sep 4, 2024 •

edited

Loading

psyray left a comment •

edited

Loading

0b3ud commented Sep 6, 2024 •

edited

Loading

sourcery-ai bot commented Sep 10, 2024 •

edited

Loading