Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(scan): custom headers #90

Merged
merged 6 commits into from
Jun 2, 2024
Merged

refactor(scan): custom headers #90

merged 6 commits into from
Jun 2, 2024

Conversation

psyray
Copy link
Contributor

@psyray psyray commented May 31, 2024

fix #19

I've refactored all the code that generate headers
Given the case that each tool has his proper format, although it is the same between multiple tools, I've decide to write some functions to manage every case properly.

Also, now 2 formats are compatible :

  • old one, string, like custom_header: 'Cookie: Test', for backward compatibility
  • new one, a dictionary, more flexible, will replace the string format
custom_header: {
  'Cookie':'Test',
  'User-Agent': 'Mozilla/5.0',
  'Custom-Header': 'My custom header'
}

Tested and working
Waiting feedback and test

@psyray psyray added the bug Something isn't working label May 31, 2024
@psyray psyray requested a review from AnonymousWP May 31, 2024 16:43
@psyray psyray self-assigned this May 31, 2024
@AnonymousWP AnonymousWP changed the title fix(scan): fix custom header refactor(scan): custom headers Jun 2, 2024
@AnonymousWP AnonymousWP merged commit b38b1b2 into master Jun 2, 2024
@AnonymousWP AnonymousWP deleted the fix-19-custom-header branch June 2, 2024 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(scan): Global Variable - custom_header does not parse correctly
2 participants