Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(install/uninstall/update): improve usability, readability and overall user experience of output #95

Merged
merged 26 commits into from
Jun 28, 2024

Conversation

@AnonymousWP AnonymousWP added the enhancement New feature or request label Jun 7, 2024
@AnonymousWP AnonymousWP changed the title build(installation): make users aware of installation time and other quality of life changes build(install): make users aware of installation time and other quality of life changes Jun 7, 2024
@AnonymousWP AnonymousWP changed the title build(install): make users aware of installation time and other quality of life changes build(install/uninstall): make users aware of installation time and other quality of life changes Jun 8, 2024
@AnonymousWP AnonymousWP changed the title build(install/uninstall): make users aware of installation time and other quality of life changes build(install/uninstall/update): improve usability, readability and overall user experience Jun 10, 2024
@AnonymousWP AnonymousWP changed the title build(install/uninstall/update): improve usability, readability and overall user experience build(install/uninstall/update): improve usability, readability and overall user experience of output Jun 10, 2024
@AnonymousWP AnonymousWP marked this pull request as ready for review June 10, 2024 14:17
@AnonymousWP
Copy link
Member Author

@Security-Tools-Alliance/developers-rengine Please test and review this. I spent quite a lot of time on testing, but it's appreciated if you find anything that can be improved or isn't working well. Thanks. 🙂

@AnonymousWP AnonymousWP requested a review from a team June 10, 2024 14:18
@AnonymousWP AnonymousWP linked an issue Jun 18, 2024 that may be closed by this pull request
3 tasks
Copy link
Contributor

@psyray psyray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Install is fine, color are clear.
Could you modify those two comments, and also the update check.
When reNgine-ng is installed, popup came with update from yogesh repo
It's located here

rengine-ng/web/api/views.py

Lines 789 to 794 in e34625c

class RengineUpdateCheck(APIView):
def get(self, request):
req = self.request
github_api = \
'https://api.github.com/repos/yogeshojha/rengine/releases'
response = requests.get(github_api).json()

scripts/uninstall.sh Show resolved Hide resolved
install.sh Outdated Show resolved Hide resolved
Copy link
Contributor

@psyray psyray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work 😉

@psyray psyray merged commit 55c9179 into master Jun 28, 2024
4 of 5 checks passed
@AnonymousWP AnonymousWP deleted the replace-names/urls-to-fork branch June 28, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

build(install): print URL of reNgine-ng after successful installation
2 participants