[EdgeDB] Add Engagement queries | refactor service/repo layers appropriately
#3219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryanjnelson
force-pushed
the
0945-engagement-queries
branch
5 times, most recently
from
79d9f5c
to
b825320
Compare
bryanjnelson
force-pushed
the
0945-engagement-queries
branch
2 times, most recently
from
acee2b1
to
a6f0625
Compare
🗞 GraphQL SummaryView schema changes@@ -1449,10 +1449,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
modifiedAt: DateTime!
parent: Project!
project: Project!
@@ -1462,9 +1462,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
input EngagementFilters {
"""Only engagements matching this type"""
@@ -2081,10 +2081,10 @@
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
intern: SecuredUser!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
mentor: SecuredUser!
methodologies: SecuredMethodologies!
modifiedAt: DateTime!
parent: InternshipProject!
@@ -2097,9 +2097,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
enum InternshipPosition {
Administration
@@ -2381,16 +2381,16 @@
disbursementCompleteDate: SecuredDateNullable!
endDate: SecuredDateNullable!
endDateOverride: SecuredDateNullable!
firstScripture: SecuredBoolean!
- historicGoal: SecuredString!
+ historicGoal: SecuredStringNullable!
"""The object's ID"""
id: ID!
initialEndDate: SecuredDateNullable!
language: SecuredLanguage!
- lastReactivatedAt: SecuredDateTime!
- lastSuspendedAt: SecuredDateTime!
+ lastReactivatedAt: SecuredDateTimeNullable!
+ lastSuspendedAt: SecuredDateTimeNullable!
"""The latest progress report that has a report submitted"""
latestProgressReportSubmitted: SecuredPeriodicReport!
lukePartnership: SecuredBoolean!
@@ -2400,9 +2400,9 @@
The progress report due next. This is the period currently in progress.
"""
nextProgressReportDue: SecuredProgressReport!
openToInvestorVisit: SecuredBoolean!
- paratextRegistryId: SecuredString!
+ paratextRegistryId: SecuredStringNullable!
parent: TranslationProject!
"""
A list of mediums used across all of the engagement's products and their
@@ -2424,9 +2424,9 @@
startDateOverride: SecuredDateNullable!
status: SecuredEngagementStatus!
"""The last time the engagement status was modified"""
- statusModifiedAt: SecuredDateTime!
+ statusModifiedAt: SecuredDateTimeNullable!
}
type LanguageEngagementListOutput implements PaginatedList {
"""Whether the next page exists"""
🚨 Breaking Changes
|
bryanjnelson
force-pushed
the
0945-engagement-queries
branch
from
9760564
to
f1cd194
Compare
bryanjnelson
force-pushed
the
0945-engagement-queries
branch
2 times, most recently
from
c6b1095
to
069b763
Compare
|
The refactoring work has been completed, and I believe this is pending some work from @CarsonF concerning the handling of the concrete types in the EdgeDB Repo. |
CarsonF
force-pushed
the
0945-engagement-queries
branch
from
9826136
to
d8bcf0f
Compare
|
Reworked with #3284 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Monday task
Description
Engagementfunctionality to prepare for EdgeDB migrationEngagementrepositoryReady for review checklist
[N/A]Add/update tests if needed