Moar camera entropy #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdmukai I reviewed this commit. I don't see any issues. I am planning to refactor the SeedStorage class to better handle mnemonic, passphrase, and bytes representing a seed. This may make the need for mnemonic_generation.py unnecessary. I think it make more sense to create a Seed class/object to pass around instead adding the overhead of converting mnemonic_to_seed every time it's needed. |
hcaklockenga
approved these changes
Aug 22, 2021
newtonick
approved these changes
Aug 22, 2021
|
Appreciate your work on this, and appreciate hcaklockenga & newtonick for the review, approving PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhances image-based entropy by chaining hashes from:
SerialAlso refactors all mnemonic processing code into a new
mnemonic_generation.py. Includes vast simplifications.Basic related test suite additions in
test_mnemonic_generation.py.