Skip to content

Commit

Permalink
Colossus Bid Adapter: update buildRequests - add tid to request data (p…
Browse files Browse the repository at this point in the history
…rebid#9056)

* add video&native traffic colossus ssp

* Native obj validation

* Native obj validation #2

* Added size field in requests

* fixed test

* fix merge conflicts

* move to 3.0

* move to 3.0

* fix IE11 new URL issue

* fix IE11 new URL issue

* fix IE11 new URL issue

* https for 3.0

* add https test

* add ccp and schain features

* fix test

* sync with upstream, fix conflicts

* Update colossussspBidAdapter.js

remove commented code

* Update colossussspBidAdapter.js

lint fix

* identity extensions

* identity extensions

* fix

* fix

* fix

* fix

* fix

* add tests for user ids

* fix

* fix

* fix

* fix

* fix

* fix

* fix

* add gdpr support

* add gdpr support

* id5id support

* Update colossussspBidAdapter.js

add bidfloor parameter

* Update colossussspBidAdapter.js

check bidfloor

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter.js

* Update colossussspBidAdapter_spec.js

* use floor module

* Revert "use floor module"

This reverts commit f0c5c24.

* use floor module

* update to 5v

* fix

* add uid2 and bidFloor support

* fix

* add pbadslot support

* fix conflicts

* add onBidWon

* refactor

* add test for onBidWon()

* fix

* add group_id

* Trigger circleci

* fix

* update user sync

* fix window.location

* fix test

* updates

* fix conflict

* fix

* updates

* remove traffic param

* add transactionId to request data for colossusssp adapter

* Send tid in placements array

Co-authored-by: Vladislav Isaiko <vladis@smartyads.com>
Co-authored-by: Aiholkin <artem.iholkin@smartyads.com>
Co-authored-by: Mykhailo Yaremchuk <m.yaremchuk@smartyads.com>
  • Loading branch information
4 people authored Sep 30, 2022
1 parent 525d824 commit 3174cd7
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
3 changes: 2 additions & 1 deletion modules/colossussspBidAdapter.js
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ export const spec = {
secure: location.protocol === 'https:' ? 1 : 0,
host: location.host,
page: location.pathname,
placements: placements,
placements: placements
};

if (bidderRequest) {
Expand All @@ -117,6 +117,7 @@ export const spec = {
placementId: bid.params.placement_id,
groupId: bid.params.group_id,
bidId: bid.bidId,
tid: bid.transactionId,
eids: [],
floor: {}
};
Expand Down
6 changes: 4 additions & 2 deletions test/spec/modules/colossussspBidAdapter_spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ describe('ColossussspAdapter', function () {
let placements = data['placements'];
for (let i = 0; i < placements.length; i++) {
let placement = placements[i];
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid');
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'sizes', 'schain', 'floor', 'gpid', 'tid');
expect(placement.schain).to.be.an('object')
expect(placement.placementId).to.be.a('number');
expect(placement.groupId).to.be.a('number');
Expand All @@ -110,6 +110,7 @@ describe('ColossussspAdapter', function () {
expect(placement.sizes).to.be.an('array');
expect(placement.floor).to.be.an('object');
expect(placement.gpid).to.be.an('string');
expect(placement.tid).to.be.an('string');
}
});

Expand Down Expand Up @@ -143,7 +144,7 @@ describe('ColossussspAdapter', function () {
let placement = placements[i];
expect(placement).to.have.all.keys('placementId', 'groupId', 'eids', 'bidId', 'traffic', 'schain', 'floor', 'gpid', 'sizes',
'playerSize', 'minduration', 'maxduration', 'mimes', 'protocols', 'startdelay', 'placement', 'skip', 'skipafter',
'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity'
'minbitrate', 'maxbitrate', 'delivery', 'playbackmethod', 'api', 'linearity', 'tid'
);
expect(placement.schain).to.be.an('object')
expect(placement.placementId).to.be.a('number');
Expand All @@ -155,6 +156,7 @@ describe('ColossussspAdapter', function () {
expect(placement.playerSize).to.be.an('array');
expect(placement.minduration).to.be.an('number');
expect(placement.maxduration).to.be.an('number');
expect(placement.tid).to.be.an('string');
}
});

Expand Down

0 comments on commit 3174cd7

Please sign in to comment.