Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the recommended FETCH NEXT x ROWS clause instead of LIMIT x #63

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

phansys
Copy link
Contributor

@phansys phansys commented Apr 10, 2023

@alanseiden
Copy link
Collaborator

Not sure about that. The IBM example was for a stored procedure using a cursor. Is that how Doctrine works?

@codecov
Copy link

codecov bot commented Apr 10, 2023

Codecov Report

Merging #63 (46735fe) into master (78b7abf) will decrease coverage by 0.89%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##             master      #63      +/-   ##
============================================
- Coverage     36.69%   35.81%   -0.89%     
- Complexity       88       89       +1     
============================================
  Files             8        8              
  Lines           218      215       -3     
============================================
- Hits             80       77       -3     
  Misses          138      138              
Impacted Files Coverage Δ
src/Platform/DB2IBMiPlatform.php 45.45% <100.00%> (-4.55%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@phansys
Copy link
Contributor Author

phansys commented Apr 10, 2023

Not sure about that. The IBM example was for a stored procedure using a cursor. Is that how Doctrine works?

Both variants are working, but I'm proposing this change because now I'm aware about this note:

The keywords FIRST and NEXT can be used interchangeably. The result is unchanged; however, using the keyword NEXT is more readable when the offset-clause is used.
The following are supported for compatibility with SQL used by other database products. These alternatives are non-standard and should not be used.

@phansys phansys marked this pull request as ready for review April 10, 2023 16:10
@alanseiden
Copy link
Collaborator

@phansys Seems okay to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants