Telegram Handler: support additional API parameters #1451
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The telegram API for sendMessage supports some additional parameters that where not yet covered with the current implementation. See the API documentation here:
https://core.telegram.org/bots/api#sendmessage
In my use case I'm mostly just interested in the
parse_mode
parameter but I thought that while I'm on it I could also add support fordisable_web_page_preview
anddisable_notification
.I didn't add support for the other remaining options because in my opinion they will never make sense when using the API for logging.
reply_to_message_id
can only be set for replies, but when logging we're not replying to a message but rather sending independent messages.reply_markup
lets the bot display an interactive interface for the user receiving the message, but the log handler can't deal with replies anyway.Something that I'm not sure about whether it's okay like this is the function argument order to the constructor. Should I move the new arguments to the end?