Fix Utils::getClass() with PHP8 #1563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per https://3v4l.org/KRpcr it seems like the parent class is anyway already returned in php8, so do we need this code at all or is get_class() not enough on php8+ ? |
|
Indeed this function has little value on PHP8+ and could be dropped at the same time than the PHP7 support. |
|
Ok sorry never mind, I had a closer look now and I see your code definitely makes more sense than including stuff like Thanks 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The results of this function differ over PHP versions since from PHP8 anonymous classes names don't necessarily start by class.
This PR takes also into account that get_class_parent() may return false.