Remove final from class declaration
#1859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most (if not all) other classes in the project are not marked as final. Although it's possible to extend the functionality of this class by using composition, it goes against how the rest of the library works for no apparent reason. In my use case, I was trying to add a field linking the log entry to a request [as described in the Cloud Logging documentation](https://cloud.google.com/run/docs/logging#correlate-logs).
|
Sure, thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most (if not all) other classes in the project are not marked as final.
Although it's possible to extend the functionality of this class by using composition, it goes against how the rest of the library works for no apparent reason.
In my use case, I was trying to add a field linking the log entry to a request as described in the Cloud Logging documentation.