-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated GelfFormatter/GelfHandler #287
Conversation
Change implementation to use bzikarks/gelf-php
Thanks! As said though I can't really merge this before 2.0, so it might be a little while. |
I totally understand. :-) |
if (!class_exists("Gelf\MessagePublisher") || !class_exists("Gelf\Message")) { | ||
$this->markTestSkipped("mlehner/gelf-php not installed"); | ||
if (!class_exists('\Gelf\Publisher') || !class_exists('\Gelf\Message')) { | ||
$this->markTestSkipped("bzikarsky/gelf-php not installed"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wrong package name here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True. Will fix that. Thanks!
Well, this took more commits than it should have. Do you want me to squash? |
If you are done with everything sure feel free to squash it |
squashed & pushed. :-) |
Since this came up several times: Monolog 2.0 seems to be far away, but people like to switch to graylog2/gelf-php. mlehner's fork is not actively developed anymore in favor of the official lib. What do you think of those 2 backwards compatible changes?
/cc @h4cc |
Addendum: So it's just a change to the constructor of the |
I'll close this PR, and open a new one with an updated description. |
Change implementation to use bzikarsky/gelf-php as discussed in Issue #258