Fix plot_pd function to work with matplotlib 3.8.0 changes #965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #965 +/- ##
=======================================
Coverage 85.23% 85.23%
=======================================
Files 74 74
Lines 8832 8834 +2
=======================================
+ Hits 7528 7530 +2
Misses 1304 1304
|
| ax_group[0][0].get_shared_y_axes().join(ax_group[0][0], *[ax[0] for ax in ax_group[1:]]) | ||
| ax_group[0][0].set_ylim(min_val, max_val) | ||
| axs = [ax[0] for ax in ax_group] | ||
| for ax1, ax2 in zip(axs, axs[1:]): |
There was a problem hiding this comment.
Is the zip necessary? I was thinking of something like:
for ax in axs[1:]:
ax.sharey(axs[0])There was a problem hiding this comment.
Good point, I've changed to your suggestion and tested that it works the same, the code is slightly nicer!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #964.
Have checked that the output plots on the
pdp_regression_bike.ipynbnotebook are the same.