-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve speed of execution for integration tests #1086
Improve speed of execution for integration tests #1086
Conversation
/test integration |
/test integration |
/test integration |
Niiice work! Getting it down to 20 mins it's awesome! |
/test integration |
/test integration |
/test integration |
/test integration |
/test integration |
1 similar comment
/test integration |
/test integration |
1 similar comment
/test integration |
/test integration |
1 similar comment
/test integration |
/test integration |
/test integration |
/test integration |
1 similar comment
/test integration |
/cc @cliveseldon Integration tests now all pass whenever KIND doesn't break 🚀 |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cliveseldon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1032 and #1084
This PR includes:
It seems that there are still some failures, which are caused from the master node crashing. This results in the Seldon (and cert) pods crashing, resulting in failure of
kubectl apply
for new models (due to the mutating/validating webhook not being reachable).An attempt to fix this was to add the requirements for min memory/CPU for system components in the KIND config file, but it still seems to be an issue. Having larger instances would probably reduce the failures due to this.
This is something that should be investigated further, but seems to be a bug related to KIND. Here is an example of the pods which fail.