Fixed Seldon golang package #1246

hemantkashniyal · 2019-12-11T17:48:50Z

Compiled code for tensorflow and seldon as a GO package

TODO: need to include make protos_go target in CI/CD build @adriangonz

seldondev · 2019-12-11T17:49:14Z

Hi @hemantkashniyal. Thanks for your PR.

I'm waiting for a SeldonIO or seldonio member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

hemantkashniyal · 2019-12-11T17:49:24Z

/assign @adriangonz

adriangonz

Thanks for your contribution @hemantkashniyal!

I've added a few comments on the PR, mostly around how the *.proto are downloaded and compiled. Besides that, I think my only remaining question would be if we should keep this on the /incubating folder or if we should move it to root folder. What do you think @cliveseldon?

Makefile

go/generate_tensorflow_proto.sh

hemantkashniyal · 2019-12-12T15:42:39Z

@adriangonz @cliveseldon it seems incubating folder contains go wrappers for preparing s2i image in go. That will anyway use these these seldon go packages.

Is incubating folder meant for supporting s2i seldon deployment image in various languages only?

Moreover these seldon go packages will also be used by go client/apps doing inference call on seldon deployment. Keeping these initially in incubating folder and later moving to root folder later may break go applications already using this code.

@adriangonz kindly review PR, have incorporated suggestions.

hemantkashniyal · 2019-12-16T16:29:43Z

Hi @adriangonz, can you please review the pull request, I have updated the changes.

adriangonz

Nice one! Thanks for making those changes @hemantkashniyal. I think this looks pretty well now.

Regarding the incubating/ folder, we use that for wrappers/clients which may not be ready yet for prime time and thus are not 100% supported. The idea is that as they become more mature and stable, they "graduate" towards stable ones which live on the root folder. However, you raise a good point regarding the imports.

What are your thoughts on this @cliveseldon @axsaucedo?

adriangonz · 2019-12-19T10:19:15Z

/ok-to-test

seldondev · 2019-12-19T10:20:36Z

Thu Dec 19 10:20:35 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=1

seldondev · 2019-12-19T10:20:39Z

Thu Dec 19 10:20:37 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=2

ukclivecox · 2019-12-19T10:28:33Z

Yes might be good to move to incubating until we are happy the solution is fully compliant to the python reference standard.

adriangonz · 2019-12-19T15:02:00Z

Got it @cliveseldon! Can you change that @hemantkashniyal? We can think of ways to reduce breaking changes when the Go wrapper is moved from incubating/ to stable in the future.

I think after that this PR should be ready to go.

Pulling main repo changes

seldondev · 2019-12-19T15:14:21Z

Thu Dec 19 15:14:20 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=3

seldondev · 2019-12-19T15:14:33Z

Thu Dec 19 15:14:32 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=4

seldondev · 2019-12-19T15:23:58Z

Thu Dec 19 15:23:57 UTC 2019
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=5

seldondev · 2019-12-19T15:24:02Z

Thu Dec 19 15:24:00 UTC 2019
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=6

seldondev · 2019-12-19T15:26:14Z

Thu Dec 19 15:26:13 UTC 2019
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=7

seldondev · 2019-12-19T15:26:26Z

Thu Dec 19 15:26:25 UTC 2019
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=8

seldondev · 2019-12-19T15:45:15Z

Thu Dec 19 15:45:13 UTC 2019
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=9

seldondev · 2019-12-19T15:45:26Z

Thu Dec 19 15:45:25 UTC 2019
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=10

hemantkashniyal · 2019-12-19T15:46:08Z

Hi @adriangonz , moved protos to incubating folder. Kindly review PR.

Following command needs to be added to CI
make -C ./incubating/wrappers/s2i/go/ compile_proto

adriangonz · 2019-12-20T14:16:47Z

/approve

Awesome! Thanks for your effort and for contributing this work! I think it looks great now!

seldondev · 2019-12-20T14:16:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

seldondev · 2019-12-20T14:18:44Z

Fri Dec 20 14:18:43 UTC 2019
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=12

seldondev · 2019-12-20T14:18:56Z

Fri Dec 20 14:18:55 UTC 2019
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1246/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1246 --build=11

hemantkashniyal added 4 commits December 11, 2019 22:37

Updated go protos

a4085e5

Updated reponame

f13191d

Updated reponame

e121b87

Added Makefile target for go proto generation

a03b4a3

seldondev added size/XXL needs-ok-to-test labels Dec 11, 2019

seldondev assigned adriangonz Dec 11, 2019

This was referenced Dec 12, 2019

Include seldon proto compilation in GO #1245

Closed

Updated Compiled Go Protos #1156

Closed

adriangonz suggested changes Dec 12, 2019

View reviewed changes

Makefile Outdated Show resolved Hide resolved

go/generate_tensorflow_proto.sh Outdated Show resolved Hide resolved

hemantkashniyal added 7 commits December 12, 2019 20:35

Updated code

9838cd5

Updated reponame

9d30963

Updated proto paths

69eb883

Updated reponame

700d5e2

Updated gitignore and root Makefile

18ea278

Updated root Makefile

05863ae

Updated root Makefile

93fdcf5

adriangonz reviewed Dec 19, 2019

View reviewed changes

seldondev added ok-to-test and removed needs-ok-to-test labels Dec 19, 2019

Merge pull request #1 from SeldonIO/master

bd0fcff

Pulling main repo changes

Moving go protos to incubating folder

5566ad5

Updated reponame in prots for testing/validation

7482d5c

reverted reponame in prots (changed for testing/validation)

fc1b98b

seldondev added the approved label Dec 20, 2019

seldondev merged commit f918a0a into SeldonIO:master Dec 20, 2019

axsaucedo unassigned adriangonz May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed Seldon golang package #1246

Fixed Seldon golang package #1246

hemantkashniyal commented Dec 11, 2019 •

edited

Loading

seldondev commented Dec 11, 2019

hemantkashniyal commented Dec 11, 2019

adriangonz left a comment

hemantkashniyal commented Dec 12, 2019 •

edited

Loading

hemantkashniyal commented Dec 16, 2019

adriangonz left a comment

adriangonz commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

ukclivecox commented Dec 19, 2019

adriangonz commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

hemantkashniyal commented Dec 19, 2019 •

edited

Loading

adriangonz commented Dec 20, 2019

seldondev commented Dec 20, 2019

seldondev commented Dec 20, 2019

seldondev commented Dec 20, 2019

Fixed Seldon golang package #1246

Fixed Seldon golang package #1246

Conversation

hemantkashniyal commented Dec 11, 2019 • edited Loading

seldondev commented Dec 11, 2019

hemantkashniyal commented Dec 11, 2019

adriangonz left a comment

Choose a reason for hiding this comment

hemantkashniyal commented Dec 12, 2019 • edited Loading

hemantkashniyal commented Dec 16, 2019

adriangonz left a comment

Choose a reason for hiding this comment

adriangonz commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

ukclivecox commented Dec 19, 2019

adriangonz commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

seldondev commented Dec 19, 2019

hemantkashniyal commented Dec 19, 2019 • edited Loading

adriangonz commented Dec 20, 2019

seldondev commented Dec 20, 2019

seldondev commented Dec 20, 2019

seldondev commented Dec 20, 2019

hemantkashniyal commented Dec 11, 2019 •

edited

Loading

hemantkashniyal commented Dec 12, 2019 •

edited

Loading

hemantkashniyal commented Dec 19, 2019 •

edited

Loading