Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update MLflow notebook #1267

Merged
merged 1 commit into from
Dec 15, 2019
Merged

Update MLflow notebook #1267

merged 1 commit into from
Dec 15, 2019

Conversation

adriangonz
Copy link
Contributor

Changelog

  • Fix default password of Grafana
  • Use namespace seldon which is now used on the Seldon Core setup notebook
  • Add tree to notebook dependencies

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

@seldondev
Copy link
Collaborator

Fri Dec 13 18:25:12 UTC 2019
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1267/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1267 --build=1

@seldondev
Copy link
Collaborator

Fri Dec 13 18:25:16 UTC 2019
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1267/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1267 --build=2

@axsaucedo
Copy link
Contributor

/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor

@adriangonz Are you sure we still want to add pygmentize and tree? I am aware we use pygmentize in other examples but tbh for these small yaml files cat would do, and if we really want to print the directory in tree form you can use the crazy ls:

ls -R | grep ":$" | sed -e 's/:$//' -e 's/[^-][^\/]*\//--/g' -e 's/^/   /' -e 's/-/|/'

@seldondev
Copy link
Collaborator

Sun Dec 15 10:30:40 UTC 2019
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1267/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1267 --build=3

@seldondev
Copy link
Collaborator

Sun Dec 15 10:30:47 UTC 2019
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1267/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1267 --build=4

@seldondev seldondev merged commit 61bc604 into SeldonIO:master Dec 15, 2019
@axsaucedo axsaucedo removed their assignment May 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants