Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gpu image Python 3 exclusive, closes #1324 #1336

Merged
merged 1 commit into from
Jan 14, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

Fix for #1324.

By symlinking pip -> pip3 and python -> python3 we ensure that all our s2i scripts that uses pip command will use pip3 for the seldon-core-s2i-python3-tf-gpu image.

@seldondev
Copy link
Collaborator

Tue Jan 14 14:28:07 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1336/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1336 --build=1

@seldondev
Copy link
Collaborator

Tue Jan 14 14:28:13 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1336/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1336 --build=2

@RafalSkolasinski
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Tue Jan 14 14:40:38 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1336/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1336 --build=3

@axsaucedo
Copy link
Contributor

Nice once @RafalSkolasinski
/approve
/lgtm

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 349bc5b into SeldonIO:master Jan 14, 2020
@axsaucedo axsaucedo removed their assignment May 13, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants