-
Notifications
You must be signed in to change notification settings - Fork 832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure unique names for webhooks #1408
Conversation
/test integration |
Wed Feb 5 11:24:29 UTC 2020 impatient try |
Wed Feb 5 11:24:30 UTC 2020 impatient try |
Wed Feb 5 11:24:46 UTC 2020 impatient try |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adriangonz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test integration |
Thu Feb 6 06:24:55 UTC 2020 impatient try |
/test integration |
Wed Feb 12 12:20:21 UTC 2020 impatient try |
Wed Feb 12 13:18:58 UTC 2020 impatient try |
Wed Feb 12 13:19:09 UTC 2020 impatient try |
Ensure unique names for webhooks
Fixes #1385
https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-configuration
If multiple webhooks are specified in a single configuration, each should be given a unique name.