Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure unique names for webhooks #1408

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Ensure unique names for webhooks #1408

merged 1 commit into from
Feb 12, 2020

Conversation

ukclivecox
Copy link
Contributor

@ukclivecox ukclivecox commented Feb 5, 2020

Fixes #1385

https://kubernetes.io/docs/reference/access-authn-authz/extensible-admission-controllers/#webhook-configuration

If multiple webhooks are specified in a single configuration, each should be given a unique name.

@ukclivecox ukclivecox added this to the 1.1 milestone Feb 5, 2020
@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Feb 5 11:24:29 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=1

@seldondev
Copy link
Collaborator

Wed Feb 5 11:24:30 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=2

@seldondev
Copy link
Collaborator

Wed Feb 5 11:24:46 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=3

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Thu Feb 6 06:24:55 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=4

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Wed Feb 12 12:20:21 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=5

@seldondev
Copy link
Collaborator

Wed Feb 12 13:18:58 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=6

@seldondev
Copy link
Collaborator

Wed Feb 12 13:19:09 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1408/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1408 --build=7

@ukclivecox ukclivecox merged commit 9acb670 into SeldonIO:master Feb 12, 2020
ukclivecox added a commit that referenced this pull request Feb 13, 2020
@ukclivecox ukclivecox deleted the 1385_webhook_names branch February 14, 2020 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v1.0.0 Seldon operator crashes when fail to deploy sdep.
3 participants