Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Events and fix State for SeldonDeployments #1570

Merged
merged 4 commits into from
Mar 22, 2020
Merged

Add Events and fix State for SeldonDeployments #1570

merged 4 commits into from
Mar 22, 2020

Conversation

ukclivecox
Copy link
Contributor

Fixes #1560

  • Creates k8s events on core transitions during operator reconcile of a new SeldonDeployment.
  • Ensures State is set to Failed and Description set if Reconcile fails

Successful deployment

sdep_events_normal

Failed deployment

sdep_events_failed

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: cliveseldon

If they are not already assigned, you can assign the PR to them by writing /assign @cliveseldon in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev
Copy link
Collaborator

Sat Mar 21 08:38:08 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=2

@seldondev
Copy link
Collaborator

Sat Mar 21 08:38:17 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=1

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Mar 21 09:35:27 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=3

Copy link
Contributor

@axsaucedo axsaucedo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I just added two questions to clarify

operator/config/rbac/role.yaml Show resolved Hide resolved
operator/constants/constants.go Outdated Show resolved Hide resolved
@seldondev
Copy link
Collaborator

Sat Mar 21 15:47:52 UTC 2020
The logs for [pr-build] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=4

@seldondev
Copy link
Collaborator

Sat Mar 21 15:48:04 UTC 2020
The logs for [lint] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=5

@seldondev
Copy link
Collaborator

Sat Mar 21 15:49:51 UTC 2020
The logs for [lint] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=7

@seldondev
Copy link
Collaborator

Sat Mar 21 15:49:51 UTC 2020
The logs for [pr-build] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=6

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Mar 21 15:53:16 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=8

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sat Mar 21 17:08:15 UTC 2020
The logs for [integration] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=9

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sun Mar 22 08:22:28 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=10

@seldondev
Copy link
Collaborator

Sun Mar 22 09:48:11 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=12

@seldondev
Copy link
Collaborator

Sun Mar 22 09:48:20 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=11

@ukclivecox
Copy link
Contributor Author

/test integration

@seldondev
Copy link
Collaborator

Sun Mar 22 10:03:57 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1570/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1570 --build=13

@seldondev
Copy link
Collaborator

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
integration 2288189 link /test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ukclivecox ukclivecox merged commit 20ef400 into SeldonIO:master Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Surface reconcile errors as Events on the SeldonDeployment
3 participants