Deployment name changes

[ukclivecox]

Fixes #1571

• Changes the way deployments are named to ensure a new deployment is created if the names of the containers changes. As new labels are created we cannot try to change an existing deployment as label selectors are immutable.
• Add notebook tests for rolling_update scenarios to check the changes

[review-notebook-app]

Check out this pull request on 

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

[seldondev]

Sun Mar 22 14:51:52 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=2

[seldondev]

Sun Mar 22 14:51:54 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=1

[adriangonz]

Nice one! I've added a few comments. I'm not sure if there may be still be a way to replicate the same issue even with the fix.

[seldondev]

Wed Mar 25 09:56:19 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=3

[seldondev]

Wed Mar 25 09:56:19 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=4

[seldondev]

Wed Mar 25 09:56:29 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=5

[seldondev]

Wed Mar 25 09:56:46 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=6

[ukclivecox]

/test integration

[seldondev]

Wed Mar 25 10:22:59 UTC 2020
The logs for [integration] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=7

[adriangonz]

/approve

[seldondev]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[seldondev]

Thu Mar 26 10:28:22 UTC 2020
The logs for [lint] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=9

[seldondev]

Thu Mar 26 10:28:25 UTC 2020
The logs for [pr-build] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=8

[ukclivecox]

/test this

[ukclivecox]

/test lint

[seldondev]

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
integration	a51f0be	link	/test integration

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[seldondev]

Thu Mar 26 20:51:48 UTC 2020
The logs for [lint] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=15

[seldondev]

Thu Mar 26 20:51:51 UTC 2020
The logs for [pr-build] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1573/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1573 --build=14