Add /scale subresource to CRD and replicas to various parts of CRD. #1633

ukclivecox · 2020-03-29T18:38:53Z

Adds /scale subresource to CRD
Adds defaultReplicas to spec
- Any predictor replicas not set will be set to spec.defaultReplicas
Add .spec.predictors[].componentSpecs[].replicas
- Allows replicas to be set just for the deployment created from the componentSpec
Adds .spec.predictors[].svcOrchSpec.replicas
Changes predictor.replicas to pointer *int32
Add defaultReplicas to status
Updates Autoscaling example and adds as notebook test
Add new scale notebook to test replica settings and scaling via kubectl
Adds docs for above

Will allow for SeldonDeployment seldon-model for example,

kubectl scale --replicas=2 sdep/seldon-model

review-notebook-app · 2020-03-29T18:38:59Z

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

seldondev · 2020-03-29T18:40:05Z

Sun Mar 29 18:40:03 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=2

seldondev · 2020-03-29T18:40:06Z

Sun Mar 29 18:40:06 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=1

ukclivecox · 2020-03-29T18:40:52Z

/test integration

seldondev · 2020-03-29T18:42:14Z

Sun Mar 29 18:42:13 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=3

seldondev · 2020-03-29T18:42:14Z

Sun Mar 29 18:42:13 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=4

seldondev · 2020-03-29T18:42:23Z

Sun Mar 29 18:42:23 UTC 2020
The logs for [integration] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=5

ukclivecox · 2020-03-29T21:40:14Z

/test notebooks

seldondev · 2020-03-29T21:41:52Z

Sun Mar 29 21:41:50 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=6

seldondev · 2020-03-30T15:00:23Z

Mon Mar 30 15:00:22 UTC 2020
The logs for [lint] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=8

seldondev · 2020-03-30T15:00:40Z

Mon Mar 30 15:00:39 UTC 2020
The logs for [pr-build] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=7

ukclivecox · 2020-03-30T15:01:01Z

/test notebooks

seldondev · 2020-03-30T15:02:24Z

Mon Mar 30 15:02:23 UTC 2020
The logs for [notebooks] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=9

ukclivecox · 2020-03-30T15:47:51Z

/test integration

seldondev · 2020-03-30T15:49:13Z

Mon Mar 30 15:49:12 UTC 2020
The logs for [integration] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=10

ukclivecox · 2020-03-30T16:29:31Z

/test notebooks

ukclivecox · 2020-03-30T16:29:42Z

/test integration

seldondev · 2020-03-30T16:30:20Z

Mon Mar 30 16:30:19 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=12

seldondev · 2020-03-30T16:30:22Z

Mon Mar 30 16:30:21 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=11

seldondev · 2020-03-30T16:30:52Z

Mon Mar 30 16:30:51 UTC 2020
The logs for [notebooks] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=13

seldondev · 2020-03-30T16:32:34Z

Mon Mar 30 16:32:33 UTC 2020
The logs for [integration] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=14

ukclivecox · 2020-03-30T16:59:07Z

/test notebooks

ukclivecox · 2020-03-30T16:59:18Z

/test integration

seldondev · 2020-03-30T17:00:48Z

Mon Mar 30 17:00:45 UTC 2020
The logs for [pr-build] [15] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/15.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=15

seldondev · 2020-03-30T17:01:01Z

Mon Mar 30 17:00:59 UTC 2020
The logs for [integration] [18] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/18.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=18

seldondev · 2020-03-30T17:01:09Z

Mon Mar 30 17:01:04 UTC 2020
The logs for [lint] [16] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/16.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=16

seldondev · 2020-03-30T17:01:09Z

Mon Mar 30 17:01:03 UTC 2020
The logs for [notebooks] [17] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/17.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=17

adriangonz

Looks pretty good!

operator/apis/machinelearning/v1/seldondeployment_types.go

testing/scripts/metrics.yaml

operator/apis/machinelearning/v1/seldondeployment_types.go

doc/source/index.rst

seldondev · 2020-04-06T08:13:04Z

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	`650ed50`	link	`/test notebooks`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

seldondev · 2020-04-06T08:25:39Z

Mon Apr 6 08:25:38 UTC 2020
The logs for [lint] [22] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/22.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=22

seldondev · 2020-04-06T08:25:48Z

Mon Apr 6 08:25:48 UTC 2020
The logs for [pr-build] [21] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/21.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=21

adriangonz · 2020-04-06T09:12:22Z

/test integration

seldondev · 2020-04-06T09:13:33Z

Mon Apr 6 09:13:32 UTC 2020
The logs for [integration] [23] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1633/23.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1633 --build=23

adriangonz · 2020-04-06T13:10:15Z

/approve

seldondev · 2020-04-06T13:10:24Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adriangonz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [adriangonz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ukclivecox added 7 commits March 29, 2020 16:28

initial scale commit

4c58f91

Merge branch 'master' into 1592_scale_subresource

cd28358

Merge branch 'master' into 1592_scale_subresource

d14a912

update replicas

40d9dea

Merge branch 'master' into 1592_scale_subresource

73be096

Update Autoscaling notebook and test

0c7f91a

update helm crd

4c963a4

seldondev added the do-not-merge/work-in-progress label Mar 29, 2020

seldondev added the size/XL label Mar 29, 2020

lint

cf0744a

ukclivecox added 2 commits March 30, 2020 15:54

Add replicas to svcorch and componentSpecs, add tests, add docs

109865d

add to test notebooks

0b3d4ef

seldondev added size/XXL and removed size/XL labels Mar 30, 2020

ukclivecox changed the title ~~WIP: Add /scale subresource to CRD~~ Add /scale subresource to CRD and replicas to various parts of CRD. Mar 30, 2020

seldondev removed the do-not-merge/work-in-progress label Mar 30, 2020

ukclivecox requested review from axsaucedo and adriangonz March 30, 2020 16:06

add scale notebook

5ed37bf

add unit tests

650ed50

adriangonz reviewed Apr 1, 2020

View reviewed changes

operator/apis/machinelearning/v1/seldondeployment_types.go Outdated Show resolved Hide resolved

testing/scripts/metrics.yaml Show resolved Hide resolved

operator/apis/machinelearning/v1/seldondeployment_types.go Outdated Show resolved Hide resolved

doc/source/index.rst Show resolved Hide resolved

change .spec.defaultReplicas to .spec.replicas

147ec4a

rebase

c172969

seldondev added the approved label Apr 6, 2020

ukclivecox merged commit 5a5e5d9 into SeldonIO:master Apr 6, 2020

Add /scale subresource to CRD and replicas to various parts of CRD. #1633

Add /scale subresource to CRD and replicas to various parts of CRD. #1633

Conversation

ukclivecox commented Mar 29, 2020 • edited Loading

review-notebook-app bot commented Mar 29, 2020

seldondev commented Mar 29, 2020

seldondev commented Mar 29, 2020

ukclivecox commented Mar 29, 2020

seldondev commented Mar 29, 2020

seldondev commented Mar 29, 2020

seldondev commented Mar 29, 2020

ukclivecox commented Mar 29, 2020

seldondev commented Mar 29, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

ukclivecox commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

seldondev commented Mar 30, 2020

adriangonz left a comment

Choose a reason for hiding this comment

seldondev commented Apr 6, 2020 • edited Loading

seldondev commented Apr 6, 2020

seldondev commented Apr 6, 2020

adriangonz commented Apr 6, 2020

seldondev commented Apr 6, 2020

adriangonz commented Apr 6, 2020

seldondev commented Apr 6, 2020

ukclivecox commented Mar 29, 2020 •

edited

Loading

seldondev commented Apr 6, 2020 •

edited

Loading