Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark model metadata in python wrapper as incubating feature in 1.1 docs #1649

Merged
merged 1 commit into from
Apr 2, 2020
Merged

mark model metadata in python wrapper as incubating feature in 1.1 docs #1649

merged 1 commit into from
Apr 2, 2020

Conversation

RafalSkolasinski
Copy link
Contributor

Remove metadata from 1.1 documentation as this will be rapidly evolving now in most-likely backward incompatible way.

May point is that right now we seemed to allow user to return from metadata method anything as long as it is dict and serve it on /metadata whereas model metadata will be very well structured in context of #1638

@seldondev
Copy link
Collaborator

Wed Apr 1 08:44:05 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1649/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1649 --build=1

@seldondev
Copy link
Collaborator

Wed Apr 1 08:44:15 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1649/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1649 --build=2

@RafalSkolasinski RafalSkolasinski changed the title remove metadata entry from 1.1 docs remove wrapper metadata entry from 1.1 docs Apr 1, 2020
@RafalSkolasinski
Copy link
Contributor Author

Alternatively instead of removing the note we could make it clear that this is a beta feature.

@RafalSkolasinski RafalSkolasinski added this to the 1.1 milestone Apr 1, 2020
@axsaucedo
Copy link
Contributor

@RafalSkolasinski that's a good idea actually, we do have already the "incubating" features, so we could actually move it into the "incubating section" for this release

@seldondev seldondev added size/S and removed size/XS labels Apr 2, 2020
@seldondev
Copy link
Collaborator

Thu Apr 2 09:37:22 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1649/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1649 --build=4

@seldondev
Copy link
Collaborator

Thu Apr 2 09:37:49 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1649/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1649 --build=3

@axsaucedo
Copy link
Contributor

/approve

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 0cad23b into SeldonIO:master Apr 2, 2020
@RafalSkolasinski RafalSkolasinski changed the title remove wrapper metadata entry from 1.1 docs mark model metadata in python wrapper as incubating feature in 1.1 docs Apr 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants