-
Notifications
You must be signed in to change notification settings - Fork 831
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mark model metadata in python wrapper as incubating feature in 1.1 docs #1649
mark model metadata in python wrapper as incubating feature in 1.1 docs #1649
Conversation
Wed Apr 1 08:44:05 UTC 2020 impatient try |
Wed Apr 1 08:44:15 UTC 2020 impatient try |
Alternatively instead of removing the note we could make it clear that this is a beta feature. |
@RafalSkolasinski that's a good idea actually, we do have already the "incubating" features, so we could actually move it into the "incubating section" for this release |
Thu Apr 2 09:37:22 UTC 2020 impatient try |
Thu Apr 2 09:37:49 UTC 2020 impatient try |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: axsaucedo The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Remove metadata from 1.1 documentation as this will be rapidly evolving now in most-likely backward incompatible way.
May point is that right now we seemed to allow user to return from
metadata
method anything as long as it isdict
and serve it on/metadata
whereas model metadata will be very well structured in context of #1638