Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added documentation for new functionality to add Dated SNAPSHOTS #1672

Merged
merged 5 commits into from
Apr 8, 2020

Conversation

axsaucedo
Copy link
Contributor

No description provided.

@seldondev
Copy link
Collaborator

Tue Apr 7 12:29:19 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=2

@seldondev
Copy link
Collaborator

Tue Apr 7 12:29:23 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=1

@seldondev
Copy link
Collaborator

Tue Apr 7 13:00:26 UTC 2020
The logs for [pr-build] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=3

@seldondev
Copy link
Collaborator

Tue Apr 7 13:00:41 UTC 2020
The logs for [lint] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=4

Copy link
Contributor

@adriangonz adriangonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I've added a small comment to add a link to the relevant page.

As a side question, what version will the charts in master point to? Is it just <next-version>-SNAPSHOT (i.e. without the timestamp)?


You can follow the instructions in the installation page to install the snapshot version.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a link here to the installation page?

@axsaucedo
Copy link
Contributor Author

/approve

@axsaucedo
Copy link
Contributor Author

/hold

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: axsaucedo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@axsaucedo
Copy link
Contributor Author

@adriangonz I just saw your comment, good point, I'll add it - also yes, in master you will always have the latest pointing to -SNAPSHOT without date

@axsaucedo
Copy link
Contributor Author

/hold remove

@seldondev
Copy link
Collaborator

Wed Apr 8 10:07:30 UTC 2020
The logs for [pr-build] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=5

@seldondev
Copy link
Collaborator

Wed Apr 8 10:07:31 UTC 2020
The logs for [lint] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1672/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1672 --build=6

@seldondev seldondev merged commit f79d58c into SeldonIO:master Apr 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants