1695 istio client #1696

ukclivecox · 2020-04-14T17:00:45Z

Reverts istio client-go to version 1.4.3 which still containers websocketupgrade in HttpRoute
Fixes explainer notebook
- Uses localhost:8003 as used in seldon core setup
- Shows explanation response .names which is the explanation

review-notebook-app · 2020-04-14T17:00:51Z

Check out this pull request on

You'll be able to see Jupyter notebook diff and discuss changes. Powered by ReviewNB.

seldondev · 2020-04-14T17:02:12Z

Tue Apr 14 17:02:11 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=1

seldondev · 2020-04-14T17:03:39Z

Tue Apr 14 17:03:37 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=2

ukclivecox · 2020-04-14T17:25:14Z

/test integration

seldondev · 2020-04-14T17:26:27Z

Tue Apr 14 17:26:26 UTC 2020
The logs for [integration] [3] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/3.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=3

ukclivecox · 2020-04-14T22:27:37Z

/test integration

ukclivecox · 2020-04-14T22:27:46Z

/test notebooks

seldondev · 2020-04-14T22:28:55Z

Tue Apr 14 22:28:54 UTC 2020
The logs for [notebooks] [5] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/5.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=5

seldondev · 2020-04-14T22:28:57Z

Tue Apr 14 22:28:56 UTC 2020
The logs for [integration] [4] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/4.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=4

ukclivecox · 2020-04-15T06:39:21Z

/test notebooks

seldondev · 2020-04-15T06:40:36Z

Wed Apr 15 06:40:35 UTC 2020
The logs for [notebooks] [6] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/6.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=6

ukclivecox · 2020-04-15T08:34:47Z

/test notebooks

seldondev · 2020-04-15T08:36:46Z

Wed Apr 15 08:36:45 UTC 2020
The logs for [notebooks] [7] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/7.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=7

ryandawsonuk

/lgtm
/approve

seldondev · 2020-04-15T09:39:05Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [ryandawsonuk]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ryandawsonuk · 2020-04-15T09:43:04Z

/retest

seldondev · 2020-04-15T09:44:30Z

Wed Apr 15 09:44:29 UTC 2020
The logs for [integration] [8] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/8.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=8

seldondev · 2020-04-15T14:47:09Z

New changes are detected. LGTM label has been removed.

seldondev · 2020-04-15T14:48:28Z

Wed Apr 15 14:48:27 UTC 2020
The logs for [lint] [10] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/10.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=10

seldondev · 2020-04-15T14:48:29Z

Wed Apr 15 14:48:28 UTC 2020
The logs for [pr-build] [9] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/9.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=9

seldondev · 2020-04-15T14:50:07Z

Wed Apr 15 14:50:06 UTC 2020
The logs for [pr-build] [11] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/11.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=11

seldondev · 2020-04-15T14:50:42Z

Wed Apr 15 14:50:41 UTC 2020
The logs for [lint] [12] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/12.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=12

ukclivecox · 2020-04-15T15:01:17Z

/hold

ukclivecox · 2020-04-15T15:01:52Z

/test integration

seldondev · 2020-04-15T15:03:55Z

Wed Apr 15 15:03:54 UTC 2020
The logs for [integration] [13] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/13.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=13

ukclivecox · 2020-04-15T17:04:12Z

/test notebooks

seldondev · 2020-04-15T17:05:39Z

Wed Apr 15 17:05:38 UTC 2020
The logs for [notebooks] [14] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1696/14.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1696 --build=14

seldondev · 2020-04-15T18:43:57Z

@cliveseldon: The following test failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
notebooks	`fc2c329`	link	`/test notebooks`

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

ukclivecox · 2020-04-15T19:27:03Z

/hold cancel

seldondev · 2021-05-13T06:34:41Z

failed to trigger Pull Request pipeline

failed to create agent
failed to calculate in repo config
failed to load trigger config for repository SeldonIO/seldon-core for ref fc2c329
failed to find any lighthouse configuration files in repo SeldonIO/seldon-core at sha fc2c329
failed to process repo SeldonIO/seldon-core refref fc2c329
failed to list files in directory /var/tmp/gitrepo660600678/.lighthouse
open /var/tmp/gitrepo660600678/.lighthouse
no such file or directory

ukclivecox added 4 commits April 14, 2020 17:33

change to older istio go client based on 1.4.3 release

b09f866

Merge branch 'master' into 1695_istio_client

fd0d8e4

Merge branch 'master' into 1695_istio_client

5214804

Fix explainer notebook

4ebac3e

ukclivecox requested a review from ryandawsonuk April 14, 2020 17:00

seldondev added the size/XL label Apr 14, 2020

ukclivecox requested a review from axsaucedo April 14, 2020 17:01

ryandawsonuk approved these changes Apr 15, 2020

View reviewed changes

seldondev assigned ryandawsonuk Apr 15, 2020

seldondev added the lgtm label Apr 15, 2020

seldondev added the approved label Apr 15, 2020

Revert gather args in client and add explainer **kwargs

df63b31

seldondev removed the lgtm label Apr 15, 2020

Increase time in alibi test

fc2c329

seldondev added the do-not-merge/hold label Apr 15, 2020

seldondev removed the do-not-merge/hold label Apr 15, 2020

ukclivecox merged commit 0832ddb into SeldonIO:master Apr 15, 2020

axsaucedo unassigned ryandawsonuk May 13, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

1695 istio client #1696

1695 istio client #1696

ukclivecox commented Apr 14, 2020 •

edited

Loading

review-notebook-app bot commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ryandawsonuk left a comment

seldondev commented Apr 15, 2020

ryandawsonuk commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented May 13, 2021

1695 istio client #1696

1695 istio client #1696

Conversation

ukclivecox commented Apr 14, 2020 • edited Loading

review-notebook-app bot commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

ukclivecox commented Apr 14, 2020

seldondev commented Apr 14, 2020

seldondev commented Apr 14, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ryandawsonuk left a comment

Choose a reason for hiding this comment

seldondev commented Apr 15, 2020

ryandawsonuk commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented Apr 15, 2020

seldondev commented Apr 15, 2020

ukclivecox commented Apr 15, 2020

seldondev commented May 13, 2021

ukclivecox commented Apr 14, 2020 •

edited

Loading