Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add number dataType to logger #1700

Merged
merged 1 commit into from
Apr 15, 2020

Conversation

ryandawsonuk
Copy link
Contributor

fixes #1699

@seldondev
Copy link
Collaborator

Wed Apr 15 13:27:59 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1700/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1700 --build=2

@seldondev
Copy link
Collaborator

Wed Apr 15 13:28:02 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-1700/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-1700 --build=1

@ryandawsonuk
Copy link
Contributor Author

/lgtm
/approve

@seldondev
Copy link
Collaborator

@ryandawsonuk: you cannot LGTM your own PR.

In response to this:

/lgtm
/approve

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ryandawsonuk

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit c841da7 into SeldonIO:master Apr 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

logger to identify single-element numeric reqs or responses as 'number'
2 participants