-
Notifications
You must be signed in to change notification settings - Fork 830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Helm chart docs #2207
Fix Helm chart docs #2207
Conversation
Tue Jul 28 12:37:22 UTC 2020 impatient try |
Tue Jul 28 12:37:26 UTC 2020 impatient try |
@@ -40,7 +40,7 @@ using: | |||
helm install $MY_MODEL_NAME seldonio/{{ .Name }} --namespace $MODELS_NAMESPACE | |||
``` | |||
|
|||
{{- end -}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If if
and else
have no -
why did they decided the have a trailing -
in the end
...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They do magic things. I think that the -
at the beginning removes the previous new line. And the -
at the end, removes the following new line (both cases if there is any).
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RafalSkolasinski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
Fix template for Helm chart docs, which was breaking the options table.
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: