Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Helm chart docs #2207

Merged
merged 1 commit into from
Jul 28, 2020
Merged

Conversation

adriangonz
Copy link
Contributor

What this PR does / why we need it:
Fix template for Helm chart docs, which was breaking the options table.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@adriangonz
Copy link
Contributor Author

/cc @RafalSkolasinski @axsaucedo

@seldondev
Copy link
Collaborator

Tue Jul 28 12:37:22 UTC 2020
The logs for [pr-build] [1] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2207/1.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2207 --build=1

@seldondev
Copy link
Collaborator

Tue Jul 28 12:37:26 UTC 2020
The logs for [lint] [2] will show after the pipeline context has finished.
https://github.com/SeldonIO/seldon-core/blob/gh-pages/jenkins-x/logs/SeldonIO/seldon-core/PR-2207/2.log

impatient try
jx get build logs SeldonIO/seldon-core/PR-2207 --build=2

@@ -40,7 +40,7 @@ using:
helm install $MY_MODEL_NAME seldonio/{{ .Name }} --namespace $MODELS_NAMESPACE
```

{{- end -}}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If if and else have no - why did they decided the have a trailing - in the end...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They do magic things. I think that the - at the beginning removes the previous new line. And the - at the end, removes the following new line (both cases if there is any).

@seldondev
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RafalSkolasinski

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@seldondev seldondev merged commit 98aeec4 into SeldonIO:master Jul 28, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants