-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extend go.mod replace rules to workaround present CVEs #2211
extend go.mod replace rules to workaround present CVEs #2211
Conversation
Addressed CVEs - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2019-0210 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-8559 - https://cve.mitre.org/cgi-bin/cvename.cgi?name=CVE-2020-14040 Introduced change have effect on go.sum: - removing it and creating again render offended deps not present Note: this does not seem to affect output of "go mod graph" command
/test integration |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Wed Jul 29 09:44:54 UTC 2020 impatient try |
Wed Jul 29 09:45:00 UTC 2020 impatient try |
Wed Jul 29 09:45:10 UTC 2020 impatient try |
Wed Jul 29 09:45:13 UTC 2020 impatient try |
Seems the only one to fail was one of the flaky tests, namely |
Wed Jul 29 11:44:34 UTC 2020 impatient try |
Now it failed on |
/test integration |
Wed Jul 29 13:37:58 UTC 2020 impatient try |
@axsaucedo It seems it was just flakiness |
/hold |
/hold |
Does this PR also update the licenses as the dependency tree is now different? Or is that out-of-scope, and we can assume that the licenses cover what we need here? |
Closing as discussed, this will be addressed by updating to kubernetes 1.18 and by reaching out to each respective project. For the meantime this is a viable workaround to override these current libraries |
Addressed CVEs
Introduced change have effect on go.sum:
Note: this does not seem to affect output of "go mod graph" command