fix(dataflow): catch all exceptions when creating a KafkaStreams object #5405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we only caught a StreamsException. However, the creation might fail for many reasons (for example, incorrect configuration). We want to catch any exception so that we mark the pipeline creation as failed and we don't stop the connection to the scheduler. Previously, on configuration errors, the exception would be bubbled to the PipelineSubscriber event loop, and the connection to the scheduler would be broken. We would try to reconnect, but on reconnect the scheduler would try to re-init the problematic pipeline (with the same id). This then led to an error about existing uncleaned KafkaStreams state in /tmp. This latter error was being handled cleanly (i.e not breaking the connection to the scheduler anymore), but would mask the real reason for the failure when looking at the pipeline status (via k8s or seldon cli).
lc525
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we only caught a StreamsException. However, the creation might fail for many reasons (for example, incorrect configuration).
We want to catch any exception so that we mark the pipeline creation as failed and we don't stop the connection to the scheduler.
Previously, on configuration errors, the exception would be bubbled to the PipelineSubscriber event loop, and the connection to the scheduler would be broken. We would try to reconnect, but on reconnect the scheduler would try to re-init the problematic pipeline (with the same id). This then led to an error about existing uncleaned KafkaStreams state in /tmp. This latter error was being handled cleanly (i.e not breaking the connection to the scheduler anymore), but would mask the real reason for the failure when looking at the pipeline status (via k8s or seldon cli).