feat: Add kube api for k6 scaffolding #5494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
reviewed
Apr 9, 2024
| @@ -152,7 +175,7 @@ function tfsimple_join_pipeline() { | |||
| seldon pipeline infer join${1} '{"inputs":[{"name":"INPUT0","data":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16],"datatype":"INT32","shape":[1,16]},{"name":"INPUT1","data":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16],"datatype":"INT32","shape":[1,16]}]}' | |||
| seldon pipeline infer join${1} --inference-mode grpc '{"model_name":"simple","inputs":[{"name":"INPUT0","contents":{"int_contents":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16]},"datatype":"INT32","shape":[1,16]},{"name":"INPUT1","contents":{"int_contents":[1,2,3,4,5,6,7,8,9,10,11,12,13,14,15,16]},"datatype":"INT32","shape":[1,16]}]}' | |||
| unload pipeline join${1} /tmp/pipelines/tfsimples-join${1}.yaml | |||
| # we cant unload the models here as they are used by other pipelines | |||
| # we cant unload the models here as they are used by other pipelines ? | |||
There was a problem hiding this comment.
This was for running multiple smoke tests in parallel, driving load to the same models. (just for context)
lc525
reviewed
Apr 9, 2024
tests/k6/k6wrapper.sh
Outdated
| @@ -12,7 +12,8 @@ if [ -f "$GOOGLE_APPLICATION_CREDENTIALS" ]; then | |||
| gcloud auth activate-service-account --key-file=$GOOGLE_APPLICATION_CREDENTIALS | |||
| fi | |||
| echo "start:"$(date) > $DIR/$METADATA | |||
| k6 $@ | |||
| # use locak k6 that is built with xk6 to include kube apis | |||
lc525
reviewed
Apr 9, 2024
tests/k6/configs/k8s/base/k6.yaml
Outdated
| @@ -35,6 +35,14 @@ spec: | |||
| # "csv=results/base.gz", | |||
| # "scenarios/infer_constant_rate.js", | |||
| # ] | |||
| # # k8s-test-script | |||
There was a problem hiding this comment.
The idea here would be that atm we'll manually comment/uncomment depending on what types of tests we want to run right?
There was a problem hiding this comment.
yes, let me revert it back to the main script.
lc525
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the necessary scaffolding to be able to use kube apis (e.g apply and delete model resources) in our k6 tests.
This is just the initial work with an simple example and we will patch our scenarios incrementally in follow up PRs.
The main addition is using xk6 which provides kubernetes api extensions in k6.
There is an example test scenario
k8s-test-script.jsthat showcases a model being created/adjusted/deleted.Other changes:
Tests:
k8s-test-script.jshas been tested as standalone script running against the current kube clusterseldon-v2-controller-managerservice account to give the k6 job kube api authseldonio/seldon-k6:latestthat contains the xk6 changesFixes INFRA-941 (internal)