fix(scheduler): Do not report back draining servers for status #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc525
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is an issue with "double" counting for models in the case of draining server replicas when then are reported with server statues. While the double counting is initially correct as we are loading models onto a different server replica while having the draining server server traffic. Once the drain process has finished and the draining server removed there is no event that triggers an update to the server statuses to reflect this change.
As eventually the draining server replica is going to get removed, we decided to just not report draining servers back on server statuses.
Also added a test to cover this edge case.
Fixes: Infra-1080 (internal)