feat(chart): add support for revisionhistorylimit (#2339)

* add support for revisionhistorylimit Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> * add support for revisionhistorylimit Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com> --------- Signed-off-by: drfaust92 <ilia.lazebnik@gmail.com>
SeleniumHQ · Aug 8, 2024 · 547f97e · 547f97e
1 parent 3433334
commit 547f97e
Show file tree

Hide file tree

Showing 10 changed files with 23 additions and 14 deletions.
diff --git a/charts/selenium-grid/templates/chrome-node-deployment.yaml b/charts/selenium-grid/templates/chrome-node-deployment.yaml
@@ -18,6 +18,7 @@ spec:
   {{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
   replicas: {{ .Values.chromeNode.replicas }}
   {{end}}
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.chromeNode.fullname" . }}

diff --git a/charts/selenium-grid/templates/distributor-deployment.yaml b/charts/selenium-grid/templates/distributor-deployment.yaml
@@ -13,6 +13,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.distributor.fullname" . }}

diff --git a/charts/selenium-grid/templates/edge-node-deployment.yaml b/charts/selenium-grid/templates/edge-node-deployment.yaml
@@ -18,6 +18,7 @@ spec:
   {{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
   replicas: {{ .Values.edgeNode.replicas }}
   {{end}}
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.edgeNode.fullname" . }}

diff --git a/charts/selenium-grid/templates/event-bus-deployment.yaml b/charts/selenium-grid/templates/event-bus-deployment.yaml
@@ -13,6 +13,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.eventBus.fullname" . }}

diff --git a/charts/selenium-grid/templates/firefox-node-deployment.yaml b/charts/selenium-grid/templates/firefox-node-deployment.yaml
@@ -18,6 +18,7 @@ spec:
   {{- if and (not .Values.autoscaling.enabled) (not .Values.autoscaling.enableWithExistingKEDA) }}
   replicas: {{ .Values.firefoxNode.replicas }}
   {{end}}
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.firefoxNode.fullname" . }}

diff --git a/charts/selenium-grid/templates/hub-deployment.yaml b/charts/selenium-grid/templates/hub-deployment.yaml
@@ -16,6 +16,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.hub.fullname" . }}

diff --git a/charts/selenium-grid/templates/router-deployment.yaml b/charts/selenium-grid/templates/router-deployment.yaml
@@ -13,6 +13,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.router.fullname" . }}

diff --git a/charts/selenium-grid/templates/session-map-deployment.yaml b/charts/selenium-grid/templates/session-map-deployment.yaml
@@ -13,6 +13,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.sessionMap.fullname" . }}

diff --git a/charts/selenium-grid/templates/session-queue-deployment.yaml b/charts/selenium-grid/templates/session-queue-deployment.yaml
@@ -13,6 +13,7 @@ metadata:
     {{- end }}
 spec:
   replicas: 1
+  revisionHistoryLimit: {{ .Values.global.seleniumGrid.revisionHistoryLimit }}
   selector:
     matchLabels:
       app: {{ template "seleniumGrid.sessionQueue.fullname" . }}

diff --git a/charts/selenium-grid/values.yaml b/charts/selenium-grid/values.yaml
@@ -27,6 +27,8 @@ global:
     defaultComponentLivenessProbe: exec
     # probe logs output can be retrieved using `kubectl logs`
     stdoutProbeLog: false
+    # specify how many old ReplicaSets for this Deployment you want to retain. The rest will be garbage-collected in the background.
+    revisionHistoryLimit: 10
 
 tls:
   # Name of external secret containing the TLS certificate and key
@@ -273,7 +275,6 @@ secrets:
 
 # Configuration for isolated components (applied only if `isolateComponents: true`)
 components:
-
   # Configuration for router component
   router:
     # imageRegistry: selenium
@@ -626,15 +627,15 @@ tracing:
   enabled: false
   enabledWithExistingEndpoint: false
   exporter: otlp
-  exporterEndpoint: 'http://{{ .Release.Name }}-jaeger-collector.{{ .Release.Namespace }}:4317'
+  exporterEndpoint: "http://{{ .Release.Name }}-jaeger-collector.{{ .Release.Namespace }}:4317"
   globalAutoConfigure: true
   ingress:
     enabled: true
     annotations:
     paths:
       - backend:
           service:
-            name: '{{ .Release.Name }}-jaeger-query'
+            name: "{{ .Release.Name }}-jaeger-query"
             port:
               number: 16686
         path: &jaegerBasePath "/jaeger"
@@ -842,9 +843,9 @@ chromeNode:
   # scaledObjectOptions:
   hpa:
     url: '{{ template "seleniumGrid.graphqlURL" . }}'
-    browserName: 'chrome'
-    sessionBrowserName: 'chrome'
-    platformName: 'linux'
+    browserName: "chrome"
+    sessionBrowserName: "chrome"
+    platformName: "linux"
     # browserVersion: '91.0' # Optional. Only required when supporting multiple versions of browser in your Selenium Grid.
     unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}'  # Optional
 
@@ -857,7 +858,6 @@ chromeNode:
   # It should be set using the --set-json option
   sidecars: []
 
-
 # Configuration for firefox nodes
 firefoxNode:
   # Enable firefox nodes
@@ -1003,9 +1003,9 @@ firefoxNode:
   # scaledObjectOptions:
   hpa:
     url: '{{ template "seleniumGrid.graphqlURL" . }}'
-    browserName: 'firefox'
-    sessionBrowserName: 'firefox'
-    platformName: 'linux'
+    browserName: "firefox"
+    sessionBrowserName: "firefox"
+    platformName: "linux"
     unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}'  # Optional
 
   # It is used to add initContainers in the same pod of the browser node.
@@ -1162,9 +1162,9 @@ edgeNode:
   # scaledObjectOptions:
   hpa:
     url: '{{ template "seleniumGrid.graphqlURL" . }}'
-    browserName: 'MicrosoftEdge'
-    sessionBrowserName: 'msedge'
-    platformName: 'linux'
+    browserName: "MicrosoftEdge"
+    sessionBrowserName: "msedge"
+    platformName: "linux"
     unsafeSsl: '{{ template "seleniumGrid.graphqlURL.unsafeSsl" . }}'  # Optional
 
   # It is used to add initContainers in the same pod of the browser node.
@@ -1218,7 +1218,7 @@ videoRecorder:
     #  RCLONE_CONFIG_GS_ENDPOINT: "https://storage.googleapis.com"
     #  RCLONE_CONFIG_GS_NO_CHECK_BUCKET: "true"
   ports:
-  - 9000
+    - 9000
   resources:
     requests:
       memory: "1Gi"