fix!: harmonized mount points to /opt/selenium/config.toml (#2343)

Authored-by: Trigtrig <7973740+Trigtrig@users.noreply.github.com>
SeleniumHQ · Aug 9, 2024 · ea50649 · ea50649
1 parent 68ebfe1
commit ea50649
Show file tree

Hide file tree

Showing 5 changed files with 12 additions and 12 deletions.
diff --git a/NodeDocker/start-selenium-grid-docker.sh b/NodeDocker/start-selenium-grid-docker.sh
@@ -98,5 +98,5 @@ java ${JAVA_OPTS:-$SE_JAVA_OPTS} \
   --subscribe-events tcp://"${SE_EVENT_BUS_HOST}":${SE_EVENT_BUS_SUBSCRIBE_PORT} \
   --bind-host ${SE_BIND_HOST} \
   --detect-drivers false \
-  --config /opt/bin/config.toml \
+  --config /opt/selenium/config.toml \
   ${SE_GRID_URL} ${SE_OPTS}
diff --git a/README.md b/README.md
@@ -758,7 +758,7 @@ $ docker run -d -p 4442-4444:4442-4444 --net grid --name selenium-hub selenium/h
 $ docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub \
     -e SE_EVENT_BUS_PUBLISH_PORT=4442 \
     -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 \
-    -v ${PWD}/config.toml:/opt/bin/config.toml \
+    -v ${PWD}/config.toml:/opt/selenium/config.toml \
     -v ${PWD}/assets:/opt/selenium/assets \
     -v /var/run/docker.sock:/var/run/docker.sock \
     selenium/node-docker:4.23.0-20240727
@@ -772,7 +772,7 @@ $ docker run -d -p 4442-4444:4442-4444 --net grid --name selenium-hub selenium/h
 $ docker run -d --net grid -e SE_EVENT_BUS_HOST=selenium-hub `
     -e SE_EVENT_BUS_PUBLISH_PORT=4442 `
     -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 `
-    -v ${PWD}/config.toml:/opt/bin/config.toml `
+    -v ${PWD}/config.toml:/opt/selenium/config.toml `
     -v ${PWD}/assets:/opt/selenium/assets `
     -v /var/run/docker.sock:/var/run/docker.sock `
     selenium/node-docker:4.23.0-20240727
@@ -793,7 +793,7 @@ $ docker network rm grid
 
 ```bash
 docker run --rm --name selenium-docker -p 4444:4444 \
-    -v ${PWD}/config.toml:/opt/bin/config.toml \
+    -v ${PWD}/config.toml:/opt/selenium/config.toml \
     -v ${PWD}/assets:/opt/selenium/assets \
     -v /var/run/docker.sock:/var/run/docker.sock \
     selenium/standalone-docker:4.23.0-20240727
@@ -803,7 +803,7 @@ docker run --rm --name selenium-docker -p 4444:4444 \
 
 ```bash
 docker run --rm --name selenium-docker -p 4444:4444 `
-    -v ${PWD}/config.toml:/opt/bin/config.toml `
+    -v ${PWD}/config.toml:/opt/selenium/config.toml `
     -v ${PWD}/assets:/opt/selenium/assets `
     -v /var/run/docker.sock:/var/run/docker.sock `
     selenium/standalone-docker:4.23.0-20240727
@@ -826,7 +826,7 @@ $ docker run -d -p 5555:5555 \
     -e SE_EVENT_BUS_HOST=<ip-from-machine-1> \
     -e SE_EVENT_BUS_PUBLISH_PORT=4442 \
     -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 \
-    -v ${PWD}/config.toml:/opt/bin/config.toml \
+    -v ${PWD}/config.toml:/opt/selenium/config.toml \
     -v ${PWD}/assets:/opt/selenium/assets \
     -v /var/run/docker.sock:/var/run/docker.sock \
     selenium/node-docker:4.23.0-20240727
@@ -839,7 +839,7 @@ $ docker run -d -p 5555:5555 `
     -e SE_EVENT_BUS_HOST=<ip-from-machine-1> `
     -e SE_EVENT_BUS_PUBLISH_PORT=4442 `
     -e SE_EVENT_BUS_SUBSCRIBE_PORT=4443 `
-    -v ${PWD}/config.toml:/opt/bin/config.toml `
+    -v ${PWD}/config.toml:/opt/selenium/config.toml `
     -v ${PWD}/assets:/opt/selenium/assets `
     -v /var/run/docker.sock:/var/run/docker.sock `
     selenium/node-docker:4.23.0-20240727
@@ -897,7 +897,7 @@ be forwared and set in the container. You can set the desired environment variab
 ```bash
 docker run --rm --name selenium-docker -p 4444:4444 \
     -e SE_NODE_SESSION_TIMEOUT=700 \
-    -v ${PWD}/config.toml:/opt/bin/config.toml \
+    -v ${PWD}/config.toml:/opt/selenium/config.toml \
     -v ${PWD}/assets:/opt/selenium/assets \
     -v /var/run/docker.sock:/var/run/docker.sock \
     selenium/standalone-docker:4.23.0-20240727
@@ -908,7 +908,7 @@ docker run --rm --name selenium-docker -p 4444:4444 \
 ```bash
 docker run --rm --name selenium-docker -p 4444:4444 `
     -e SE_NODE_SESSION_TIMEOUT=700 `
-    -v ${PWD}/config.toml:/opt/bin/config.toml `
+    -v ${PWD}/config.toml:/opt/selenium/config.toml `
     -v ${PWD}/assets:/opt/selenium/assets `
     -v /var/run/docker.sock:/var/run/docker.sock `
     selenium/standalone-docker:4.23.0-20240727

diff --git a/StandaloneDocker/start-selenium-grid-docker.sh b/StandaloneDocker/start-selenium-grid-docker.sh
@@ -84,5 +84,5 @@ java ${JAVA_OPTS:-$SE_JAVA_OPTS} \
   --relax-checks ${SE_RELAX_CHECKS} \
   --detect-drivers false \
   --bind-host ${SE_BIND_HOST} \
-  --config /opt/bin/config.toml \
+  --config /opt/selenium/config.toml \
   ${SE_GRID_URL} ${SE_OPTS}
diff --git a/docker-compose-v3-dynamic-grid.yml b/docker-compose-v3-dynamic-grid.yml
@@ -7,7 +7,7 @@ services:
     image: selenium/node-docker:4.23.0-20240727
     volumes:
       - ./assets:/opt/selenium/assets
-      - ./NodeDocker/config.toml:/opt/bin/config.toml
+      - ./NodeDocker/config.toml:/opt/selenium/config.toml
       - /var/run/docker.sock:/var/run/docker.sock
     depends_on:
       - selenium-hub

diff --git a/tests/docker-compose-v3-test-node-docker.yaml b/tests/docker-compose-v3-test-node-docker.yaml
@@ -4,7 +4,7 @@ services:
     image: ${NAMESPACE}/node-docker:${TAG}
     volumes:
       - ./videos:/opt/selenium/assets
-      - ./videos/config.toml:/opt/bin/config.toml
+      - ./videos/config.toml:/opt/selenium/config.toml
       - /var/run/docker.sock:/var/run/docker.sock
       - ./videos/Downloads:/home/seluser/Downloads
     dns: