Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add affinity to helm charts #1851

Merged
merged 2 commits into from
May 18, 2023
Merged

Conversation

bschreder
Copy link
Contributor

add affinity to helm charts top support nodeAffinity, podAffinity, and podAntiAffinity

Description

Added global and component/browser affinity selectors to the helm charts. The global setting, as suggested per issue #1763, affects all components. Additional, individual components can set their affinity and will override the global settings.
Affinity information is available at https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/

Additional, I updated tolerations to remove the blank line

Motivation and Context

It allows tests to run across multiple nodepools with preference toward the lower cost nodepools.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • [x ] I have read the contributing document.
  • [x ] My change requires a change to the documentation.
  • [x ] I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented May 17, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @bschreder!

@diemol diemol merged commit 968bee7 into SeleniumHQ:trunk May 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants