Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driverversion): Switching CFT driver endpoints #1948

Merged
merged 1 commit into from
Sep 20, 2023
Merged

fix(driverversion): Switching CFT driver endpoints #1948

merged 1 commit into from
Sep 20, 2023

Conversation

amardeep2006
Copy link
Contributor

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

This PR is for issue discussed #1944
With the existing CFT endpoints for chromedrivers, I observered mismatched Major version of chrome and chrome driver.
With new approach we are first calculating Chrome version and then downloading latest driver version.

Motivation and Context

Chrome browser does not get launched if there is a mismatch in driver and chrome.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Sep 20, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @amardeep2006!

@diemol diemol merged commit ccfaa9c into SeleniumHQ:trunk Sep 20, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: Mismatch between Chrome and chrome driver version - Major Issue
3 participants