Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Ingress namespace field #1966

Merged
merged 2 commits into from
Oct 4, 2023

Conversation

IronMage
Copy link
Contributor

@IronMage IronMage commented Oct 3, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Selenium Grid chart does not include the release namespace in the object definition, causing it to be deployed to the default namespace rather than the target namespace.

Motivation and Context

Deploying with the helm --namespace flag causes the ingress to potentially be deployed to a different namespace.

Types of changes

  • [ x] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @IronMage!

@diemol diemol merged commit 410ca81 into SeleniumHQ:trunk Oct 4, 2023
4 checks passed
@IronMage
Copy link
Contributor Author

IronMage commented Oct 4, 2023

@diemol Will you be re-packaging selenium-grid-0.21.3? I can also put in a PR to bump the version to 0.21.4 instead.

@diemol
Copy link
Member

diemol commented Oct 4, 2023

Sorry, I missed this. I already released it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants