Skip to content

Commit

Permalink
Deleting "bad" test
Browse files Browse the repository at this point in the history
  • Loading branch information
barancev committed Apr 7, 2017
1 parent cfcfcee commit 0606379
Showing 1 changed file with 0 additions and 13 deletions.
13 changes: 0 additions & 13 deletions java/client/test/org/openqa/selenium/CorrectEventFiringTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,6 @@ public void testShouldFireMouseOverEventWhenClicking() {
assertEventFired("mouseover");
}

// TODO: this is a bad test: mousemove should not fire in a perfect click (e.g. mouse did not move
// while doing down, up, click
@JavascriptEnabled
@Test
@Ignore(MARIONETTE)
public void testShouldFireMouseMoveEventWhenClicking() {
driver.get(pages.javascriptPage);

clickOnElementWhichRecordsEvents();

assertEventFired("mousemove");
}

@JavascriptEnabled
@Test
public void testShouldNotThrowIfEventHandlerThrows() {
Expand Down

3 comments on commit 0606379

@shs96c
Copy link
Member

@shs96c shs96c commented on 0606379 Apr 10, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't quite right. We just loaded the page, and the native mouse is assumed to be at 0,0 (or the last location the mouse was in) In order to click the element, the mouse will have to move towards it. The comment was wrong, the test was correct.

@barancev
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider this to be a marionette bug? What paragraph of the spec can we refer to?

@shs96c
Copy link
Member

@shs96c shs96c commented on 0606379 Apr 21, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

w3c/webdriver#897 It's a marionette bug

Please sign in to comment.