Merge branch 'trunk' into add-duration-to-action-constructor

SeleniumHQ · Jun 13, 2024 · 0ef4c94 · 0ef4c94
2 parents 3da9a0f + 9938f15
commit 0ef4c94
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/py/test/unit/selenium/webdriver/common/common_options_tests.py b/py/test/unit/selenium/webdriver/common/common_options_tests.py
@@ -94,4 +94,4 @@ def test_set_socket_url():
     options = ArgOptions()
     options.web_socket_url = "socket_url"
     assert options.enable_bidi is True
-    assert options.web_socket_url is "socket_url"
+    assert options.web_socket_url == "socket_url"
diff --git a/rb/.rubocop.yml b/rb/.rubocop.yml
@@ -78,6 +78,8 @@ Metrics/PerceivedComplexity:
 Naming/FileName:
   Exclude:
     - 'lib/selenium-webdriver.rb'
+    - 'Rakefile'
+    - '../Rakefile'
 
 Naming/MethodParameterName:
   AllowedNames:

diff --git a/rb/spec/integration/selenium/webdriver/driver_spec.rb b/rb/spec/integration/selenium/webdriver/driver_spec.rb
@@ -147,10 +147,7 @@ module WebDriver
           }.to raise_error(Error::NoSuchElementError, /errors#no-such-element-exception/)
         end
 
-        it 'raises if invalid locator',
-           except: {browser: %i[chrome edge],
-                    reason: 'https://bugs.chromium.org/p/chromedriver/issues/detail?id=4743'},
-           exclude: {browser: %i[safari safari_preview], reason: 'Safari TimeoutError'} do
+        it 'raises if invalid locator', exclude: {browser: %i[safari safari_preview], reason: 'Safari TimeoutError'} do
           driver.navigate.to url_for('xhtmlTest.html')
           expect {
             driver.find_element(xpath: '*?//-')