[oy] Fix issue with w3c actions releasing on element (#5180)

Releasing a held mouse button on an element
SeleniumHQ · Dec 7, 2017 · 2430a64 · 2430a64
1 parent c067d6b
commit 2430a64
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/py/selenium/webdriver/common/action_chains.py b/py/selenium/webdriver/common/action_chains.py
@@ -331,12 +331,12 @@ def release(self, on_element=None):
          - on_element: The element to mouse up.
            If None, releases on current mouse position.
         """
+        if on_element:
+                self.move_to_element(on_element)
         if self._driver.w3c:
             self.w3c_actions.pointer_action.release()
             self.w3c_actions.key_action.pause()
         else:
-            if on_element:
-                self.move_to_element(on_element)
             self._actions.append(lambda: self._driver.execute(Command.MOUSE_UP, {}))
         return self