Skip to content

Commit

Permalink
Unignoring a bunch of tests in marionette, file uploading and d-n-d w…
Browse files Browse the repository at this point in the history
…ork now
  • Loading branch information
barancev committed Aug 17, 2017
1 parent fe0476d commit 4be56fb
Show file tree
Hide file tree
Showing 6 changed files with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -345,7 +345,6 @@ public void testSubmittingFormFromFormInputTextElementShouldFireOnSubmitForThatF

@Test
@Ignore(value = SAFARI, reason = "Does not yet support file uploads, issue 4220")
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testUploadingFileShouldFireOnChangeEvent() throws IOException {
driver.get(pages.formPage);
WebElement uploadElement = driver.findElement(By.id("upload"));
Expand Down
3 changes: 0 additions & 3 deletions java/client/test/org/openqa/selenium/FormHandlingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,6 @@ public void testShouldEnterDataIntoFormFields() {

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws IOException {
driver.get(pages.formPage);
WebElement uploadElement = driver.findElement(By.id("upload"));
Expand All @@ -176,7 +175,6 @@ public void testShouldBeAbleToAlterTheContentsOfAFileUploadInputElement() throws

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument()
throws IOException {
assumeFalse("IE before 9 doesn't handle pages served with an XHTML content type,"
Expand All @@ -198,7 +196,6 @@ public void testShouldBeAbleToSendKeysToAFileUploadInputElementInAnXhtmlDocument

@Test
@Ignore(value = SAFARI, reason = "issue 4220")
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testShouldBeAbleToUploadTheSameFileTwice() throws IOException {
File file = File.createTempFile("test", "txt");
file.deleteOnExit();
Expand Down
1 change: 0 additions & 1 deletion java/client/test/org/openqa/selenium/PageLoadingTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,6 @@ public void testShouldTimeoutIfAPageTakesTooLongToLoad() {

@NoDriverAfterTest // Subsequent tests sometimes fail on Firefox.
@Test
@Ignore(value = MARIONETTE)
@Ignore(value = SAFARI, reason = "issue 687, comment 41")
@NeedsLocalEnvironment
public void testShouldTimeoutIfAPageTakesTooLongToLoadAfterClick() {
Expand Down
2 changes: 0 additions & 2 deletions java/client/test/org/openqa/selenium/UploadTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,6 @@ public void setUp() throws Exception {

@SwitchToTopAfterTest
@Test
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testFileUploading() throws Exception {
assumeFalse(
"This test as written assumes a file on local disk is accessible to the browser. "
Expand All @@ -84,7 +83,6 @@ public void testFileUploading() throws Exception {
@Ignore(IE)
@Ignore(PHANTOMJS)
@Ignore(SAFARI)
@NotYetImplemented(value = MARIONETTE, reason = "https://github.com/mozilla/geckodriver/issues/644")
public void testCleanFileInput() throws Exception {
driver.get(pages.uploadPage);
WebElement element = driver.findElement(By.id("upload"));
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,6 @@ public void testMovingMouseToRelativeZeroElementOffset() {

@NeedsFreshDriver({IE, CHROME})
@Test
@Ignore(MARIONETTE)
@NotYetImplemented(HTMLUNIT)
public void testMoveRelativeToBody() {
try {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,6 @@
public class DragAndDropTest extends JUnit4TestBase {

@Test
@Ignore(MARIONETTE)
public void testDragAndDropRelative() {
assumeFalse("See issue 2281", TestUtilities.getEffectivePlatform().is(Platform.MAC));
assumeFalse(Browser.detect() == Browser.opera &&
Expand All @@ -73,7 +72,6 @@ public void testDragAndDropRelative() {
}

@Test
@Ignore(MARIONETTE)
public void testDragAndDropToElement() {
driver.get(pages.dragAndDropPage);
WebElement img1 = driver.findElement(By.id("test1"));
Expand Down

0 comments on commit 4be56fb

Please sign in to comment.