Skip to content

Commit

Permalink
[dotnet] Add reflection-based JSON serialization fallback to `Command…
Browse files Browse the repository at this point in the history
…`s (#14732)
  • Loading branch information
RenderMichael authored Nov 8, 2024
1 parent f8d6c36 commit 5c9d683
Show file tree
Hide file tree
Showing 2 changed files with 43 additions and 1 deletion.
3 changes: 2 additions & 1 deletion dotnet/src/webdriver/Command.cs
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
using System.Collections.Generic;
using System.Text.Json;
using System.Text.Json.Serialization;
using System.Text.Json.Serialization.Metadata;

namespace OpenQA.Selenium
{
Expand All @@ -35,7 +36,7 @@ public class Command

private readonly static JsonSerializerOptions s_jsonSerializerOptions = new()
{
TypeInfoResolver = CommandJsonSerializerContext.Default,
TypeInfoResolver = JsonTypeInfoResolver.Combine(CommandJsonSerializerContext.Default, new DefaultJsonTypeInfoResolver()),
Converters = { new ResponseValueJsonConverter() }
};

Expand Down
41 changes: 41 additions & 0 deletions dotnet/test/common/CommandTests.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
// <copyright file="CommandTests.cs" company="Selenium Committers">
// Licensed to the Software Freedom Conservancy (SFC) under one
// or more contributor license agreements. See the NOTICE file
// distributed with this work for additional information
// regarding copyright ownership. The SFC licenses this file
// to you under the Apache License, Version 2.0 (the
// "License"); you may not use this file except in compliance
// with the License. You may obtain a copy of the License at
//
// http://www.apache.org/licenses/LICENSE-2.0
//
// Unless required by applicable law or agreed to in writing,
// software distributed under the License is distributed on an
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
// KIND, either express or implied. See the License for the
// specific language governing permissions and limitations
// under the License.
// </copyright>

using NUnit.Framework;
using System.Collections.Generic;

namespace OpenQA.Selenium
{
[TestFixture]
public class CommandTests
{
[Test]
public void CommandSerializesAnonymousType()
{
var parameters = new Dictionary<string, object>
{
["arg"] = new { param1 = true, param2 = false },
};

var command = new Command(new SessionId("session"), "test command", parameters);

Assert.That(command.ParametersAsJsonString, Is.EqualTo("""{"arg":{"param1":true,"param2":false}}"""));
}
}
}

0 comments on commit 5c9d683

Please sign in to comment.