Setting HtmlUnit to emulate FF24 by default

SeleniumHQ · Jun 11, 2014 · 719bffd · 719bffd
1 parent 3b2b574
commit 719bffd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 7 deletions.
diff --git a/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java b/java/client/src/org/openqa/selenium/htmlunit/HtmlUnitDriver.java
@@ -231,7 +231,7 @@ static BrowserVersion determineBrowserVersion(Capabilities capabilities) {
     }
 
     if (BrowserType.FIREFOX.equals(browserName)) {
-      return BrowserVersion.FIREFOX_17;
+      return BrowserVersion.FIREFOX_24;
     }
 
     if (BrowserType.CHROME.equals(browserName)) {

diff --git a/java/client/test/org/openqa/selenium/ClickTest.java b/java/client/test/org/openqa/selenium/ClickTest.java
@@ -287,7 +287,7 @@ public void testCanClickAnImageMapArea() {
   }
 
   @Test
-  @Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
+  @Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
       = "Not tested against these browsers")
   public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() {
     String url = appServer.whereIs("click_too_big.html");
@@ -301,7 +301,7 @@ public void testShouldBeAbleToClickOnAnElementGreaterThanTwoViewports() {
   }
 
   @Test
-  @Ignore(value = {CHROME, HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
+  @Ignore(value = {CHROME, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
       = "Chrome: failed, Firefox: failed with native events, others: not tested")
   public void testShouldBeAbleToClickOnAnElementInFrameGreaterThanTwoViewports() {
     assumeFalse(isFirefox(driver) && isNativeEventsEnabled(driver));
@@ -331,7 +331,7 @@ public void testShouldBeAbleToClickOnRTLLanguageLink() {
   }
 
   @Test
-  @Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
+  @Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
       = "not tested")
   public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooter() {
     String url = appServer.whereIs("fixedFooterNoScroll.html");
@@ -344,7 +344,7 @@ public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooter() {
   }
 
   @Test
-  @Ignore(value = {HTMLUNIT, OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
+  @Ignore(value = {OPERA, OPERA_MOBILE, ANDROID, IPHONE, MARIONETTE}, reason
       = "not tested")
   public void testShouldBeAbleToClickOnLinkInAbsolutelyPositionedFooterInQuirksMode() {
     String url = appServer.whereIs("fixedFooterNoScrollQuirksMode.html");

diff --git a/java/client/test/org/openqa/selenium/htmlunit/HtmlUnitCapabilitiesTest.java b/java/client/test/org/openqa/selenium/htmlunit/HtmlUnitCapabilitiesTest.java
@@ -44,7 +44,7 @@ public void configurationViaDirectCapabilities() {
         new DesiredCapabilities(BrowserType.FIREFOX, "", Platform.ANY);
 
     assertEquals(HtmlUnitDriver.determineBrowserVersion(firefoxCapabilities),
-        BrowserVersion.FIREFOX_17);
+        BrowserVersion.FIREFOX_24);
   }
 
   @Test
@@ -53,7 +53,7 @@ public void configurationOfFirefoxViaRemote() {
         new DesiredCapabilities(BrowserType.HTMLUNIT, "firefox", Platform.ANY);
 
     assertEquals(HtmlUnitDriver.determineBrowserVersion(firefoxCapabilities),
-        BrowserVersion.FIREFOX_17);
+        BrowserVersion.FIREFOX_24);
   }
 
   @Test