-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[🐛 Bug]: There are still some leftovers from the HtmlUnit removal #13171
Comments
@rbri, thank you for creating this issue. We will troubleshoot it as soon as we can. Info for maintainersTriage this issue by using labels.
If information is missing, add a helpful comment and then
If the issue is a question, add the
If the issue is valid but there is no time to troubleshoot it, consider adding the
If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
add the applicable
After troubleshooting the issue, please add the Thank you! |
Thank you for reporting and providing the issue. Would you like to send a PR and help contribute? :) |
This issue is looking for contributors. Please comment below or reach out to us through our IRC/Slack/Matrix channels if you are interested. |
Sorry i really have no time to work on that - maybe @joerg1985 who did the original pr for removing has an idea why we still have this dependency. |
I will take care of this, as soon as i find the time. |
Updates the HtmlUnit Java dependency to the latest major release according to the migration guide: https://www.htmlunit.org/migration.html Resolves: vulnerability CVE-2023-26119 Related SeleniumHQ#13171
Updates the HtmlUnit Java dependency to the latest major release according to the migration guide: https://www.htmlunit.org/migration.html Resolves: vulnerability CVE-2023-26119 Related SeleniumHQ#13171
Updates the HtmlUnit Java dependency to the latest major release according to the migration guide: https://www.htmlunit.org/migration.html Resolves: vulnerability CVE-2023-26119 Related #13171 Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
@diemol did that PR fix this issue? |
@titusfortner sorry but the pr updates the htmlunit dependencies instead of removing it And btw: Happy new year to you all |
@rbri i think these files are generated by bazel at build time and should be in place as soon as the tests are running: selenium/java/test/org/openqa/selenium/atoms/BUILD.bazel Lines 4 to 16 in b2a8448
After running |
ok, i see having this dependency to htmlunit-core-js still makes sense. @joerg1985 / @diemol do you like to close or should i do? |
This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
What happened?
Looks like there are some leftovers from [java] remove the unused htmlunit-driver from the unit tests (#12849).
How can we reproduce the issue?
Relevant log output
Operating System
any
Selenium version
any
What are the browser(s) and version(s) where you see this issue?
any
What are the browser driver(s) and version(s) where you see this issue?
any
Are you using Selenium Grid?
no
The text was updated successfully, but these errors were encountered: