Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dotnet] Change signature of GetDownloadableFiles to IEnumerable<string>? #13264

Closed
nvborisenko opened this issue Dec 7, 2023 · 2 comments · Fixed by #13265
Closed

[dotnet] Change signature of GetDownloadableFiles to IEnumerable<string>? #13264

nvborisenko opened this issue Dec 7, 2023 · 2 comments · Fixed by #13265
Labels
C-dotnet

Comments

@nvborisenko
Copy link
Member

nvborisenko commented Dec 7, 2023 •
edited
Loading

https://github.com/SeleniumHQ/selenium/blob/1bcb948894767cf4525b565f0c5dac73cd3e15e0/dotnet/src/webdriver/IHasDownloads.cs#L32C9-L32C9

List<string> GetDownloadableFiles(); allows add new items to the list.

I think it would be better to use IReadonlyList<string> or IEnumerable<string> (or any other immutable interface friendly with Linq). It is breaking change, but would not be widely spread.
@nvborisenko
Copy link
Member Author

IReadOnlyList<string> is my preference here.

@nvborisenko nvborisenko mentioned this issue Dec 7, 2023
Merged
8 tasks
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 7, 2024

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-dotnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[dotnet] Change a list of downloadable files to IReadOnlyList nvborisenko/selenium-hq
1 participant
@nvborisenko