[dotnet] Change a list of downloadable files to IReadOnlyList

[nvborisenko]

Description

Retrieved list should be immutable.

Motivation and Context

Fixes #13264

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist

• I have read the contributing document.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have added tests to cover my changes.
• All new and existing tests passed.

[titusfortner]

Is this change worth breaking backwards compatibility without warning?

[nvborisenko]

There are 2 types of breaking changes: compilation compatibility and binary compatibility. This change is related to binary compatibility (even not sure), and is not related to compilation compatibility. I suppose only 0.01% of users might be impacted.

[nvborisenko]

I lied, it is compilation level breaking change. It breaks users who wrote:

List<string> myVar = driver.GetDownloadableFiles();

[titusfortner]

I see how it is. Still want to do it, or put it back?

[nvborisenko]

Now or later... Given that selenium doesn't follow semver...

…

On Fri, Dec 8, 2023, 12:09 AM Titus Fortner ***@***.***> wrote: I see how it is. Still want to do it, or put it back? — Reply to this email directly, view it on GitHub <#13265 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFMRXHUCFMN2BT7JGXZLDRLYIIWB7AVCNFSM6AAAAABALRIZ2SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNBWGEYTMNJYGY> . You are receiving this because you authored the thread.Message ID: ***@***.***>