Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade guide from selenium-webdriver for nodejs 2.53.2 to 3.0.0 #3062

Closed
doberkofler opened this issue Nov 4, 2016 · 6 comments
Closed

Upgrade guide from selenium-webdriver for nodejs 2.53.2 to 3.0.0 #3062

doberkofler opened this issue Nov 4, 2016 · 6 comments
Labels
C-docs C-nodejs

Comments

@doberkofler
Copy link

Upgrading from selenium-webdriver for nodejs 2.53.2 to version 3 seems to be quite a task and it would really help to have some upgrade guide that details where the breaking changes in the API and how to migrate the existing code.
@jleyba
Copy link
Contributor

jleyba commented Nov 6, 2016

https://github.com/SeleniumHQ/selenium/blob/master/javascript/node/selenium-webdriver/CHANGES.md

@jleyba jleyba closed this as completed Nov 6, 2016
@doberkofler
Copy link
Author

@jleyba I did read the change log but with the amount of changes, I believe that an migration document explaining how to migrate existing code would be very helpful.

@jleyba
Copy link
Contributor

jleyba commented Nov 8, 2016

Are you talking about the promise manager deprecation ( #2969)? Yeah, I can throw together a guide for that.

@jleyba jleyba reopened this Nov 8, 2016
@doberkofler
Copy link
Author

@jleyba I think this would be very helpful.

jleyba added a commit that referenced this issue Feb 20, 2017
@jleyba
[js] Log a warning if the user creates a managed promise or schedules an
ed6dc8e 
unchained task (which relies on the promise manager for proper synchronization).
See CHANGES.md for instructions on printing these messages to the console.

These changes are intended to help users find code that still relies on the
promise manager (#2969, #3062)
@jleyba
Copy link
Contributor

jleyba commented Mar 6, 2017

I've updated the wiki with tips on migrating:

https://github.com/SeleniumHQ/selenium/wiki/WebDriverJs

@jleyba jleyba closed this as completed Mar 6, 2017
@manoj9788
Copy link
Member

manoj9788 commented Mar 6, 2017 •
edited
Loading

Speaking version of these changes could be heard soon during the SeConf in April. Thanks Jason.

antonyoneill pushed a commit to antonyoneill/selenium that referenced this issue May 10, 2017
@jleyba
Update the WebDriverJS wiki with info on migrating off the promise ma…
986b5cf 
…nager (Fixes SeleniumHQ#3062)
@lock lock bot locked and limited conversation to collaborators Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
C-docs C-nodejs
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@jleyba @lukeis @doberkofler @manoj9788