Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'npm install selenium-webdriver' failed with iojs 3.0.0 #904

Closed
Dzenly opened this issue Aug 9, 2015 · 9 comments
Closed

'npm install selenium-webdriver' failed with iojs 3.0.0 #904

Dzenly opened this issue Aug 9, 2015 · 9 comments

Comments

@Dzenly
Copy link

Dzenly commented Aug 9, 2015

I created an issue here:
nodejs/node#2337

@Dzenly Dzenly closed this as completed Aug 9, 2015
@Dzenly Dzenly reopened this Aug 9, 2015
@Dzenly Dzenly changed the title Build with iojs 3.0.0 failed (on windows at least) Build selenium-webdriver npm module with iojs 3.0.0 failed (on windows at least) Aug 9, 2015
@lukeis
Copy link
Member

lukeis commented Aug 10, 2015

can you please leave a better description here? like how to reproduce your issue (example steps of what you're doing to 'build')

@Dzenly Dzenly changed the title Build selenium-webdriver npm module with iojs 3.0.0 failed (on windows at least) 'npm install selenium-webdriver' failed with iojs 3.0.0 Aug 10, 2015
@Dzenly
Copy link
Author

Dzenly commented Aug 10, 2015

Ok, I changed the subject to be crystal clear. Sorry for such garbage (I am beginner here).
In fact guys from iojs already understood the problem and made pull requests to according modules which selenium-webdriver depends on (they use old nan module). Though it is not iojs problem.

@jleyba
Copy link
Contributor

jleyba commented Aug 11, 2015

Iojs is not an officially supported platform. The selenium-webdriver npm module supports the last two stable releases for node: 0.10.x & 0.12.x. iojs is like node 0.11/0.13: if it works, great. If not - sorry.

That said, I'd be happy to review any PRs that address iojs issues. For now, I'm closing this because there's no action required by the Selenium project.

@jleyba jleyba closed this as completed Aug 11, 2015
@Dzenly
Copy link
Author

Dzenly commented Aug 11, 2015

You'd be happy to review PR from iojs, but with sorry :) Okaay :)

@jleyba
Copy link
Contributor

jleyba commented Aug 11, 2015

I guess it is a weird position: "we'll accept your PR, but won't make promises about it working long term."

Let me try again:

As the sole maintainer of Selenium's client library for node, I don't consider iojs a supported platform. My time with Selenium is limited these days and it would not be prudent for me to extend support to a new platform. Community contributions to support iojs along with node are welcome and will not be rejected on the grounds of iojs being "unsupported". Unfortunately, until more members of the Selenium project start working on the JS client, official support will remain focused on node and regressions may crop up.

Having a single project member dedicated to one of the client language bindings is not ideal, but that's just how things have worked out. Members tend to focus on maintaining bindings for the languages they work in.

The TL;DR is still the same as before, but hopefully my position is easier to understand.

@Dzenly
Copy link
Author

Dzenly commented Aug 11, 2015

Understood. I didn't know that you are alone on this project. Great thank you for your work!

@lseongjoo
Copy link

npm install fails with io.js 3.0.0 on OS X too. And, thank you jleyba for the great work.

@Dzenly
Copy link
Author

Dzenly commented Aug 26, 2015

Now it is absolutely selenium-webdriver problem. Due to using "ws": "^0.7.1" in package.json.
What if you will change it to "^0.8.0"?

@Dzenly
Copy link
Author

Dzenly commented Sep 9, 2015

Okaay :) Is new nodejs 4.0.0 "officially supported platform" ?
https://nodejs.org/en/blog/release/v4.0.0/

jleyba added a commit that referenced this issue Sep 15, 2015
@lock lock bot locked and limited conversation to collaborators Aug 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants