Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[py]: Remove unused arg resolve_ip from RemoteConnection initialiser #10717

Merged
merged 2 commits into from
Jun 9, 2022

Conversation

symonk
Copy link
Member

@symonk symonk commented May 31, 2022

resolve_ip has been unused for quite some time; removed it as an arg to RemoteConnection

@codecov-commenter
Copy link

Codecov Report

Merging #10717 (2617d7e) into trunk (f677d2d) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##            trunk   #10717      +/-   ##
==========================================
- Coverage   46.64%   46.63%   -0.02%     
==========================================
  Files          86       86              
  Lines        5855     5850       -5     
  Branches      278      278              
==========================================
- Hits         2731     2728       -3     
+ Misses       2846     2844       -2     
  Partials      278      278              
Impacted Files Coverage Δ
py/selenium/webdriver/remote/remote_connection.py 30.49% <0.00%> (-0.52%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f677d2d...2617d7e. Read the comment docs.

@symonk symonk merged commit 27ff586 into SeleniumHQ:trunk Jun 9, 2022
@symonk symonk deleted the remove-unused-resolve-ip branch June 9, 2022 18:59
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
…ser (SeleniumHQ#10717)

Remove unused arg `resolve_ip` from `RemoteConnection` initialiser
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants